Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1963)

Issue 6443068: Optimized hit testing feature, refactored into seperate function from canvas draw calls (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 11 months ago by chudy
Modified:
11 years, 11 months ago
Reviewers:
DerekS
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlecode.com/svn/trunk
Visibility:
Public.

Description

Optimized hit testing feature, refactored into seperate function from canvas draw calls Committed: https://code.google.com/p/skia/source/detail?r=4867

Patch Set 1 : Optimized hit testing feature, refactored into seperate function from canvas draw calls #

Patch Set 2 : Removed bitmap parameter from drawTo in debugcanvas, fixed assert bug" #

Patch Set 3 : Removed deprecated comment #

Total comments: 4

Patch Set 4 : Addressed patch 1 comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -230 lines) Patch
M debugger/QT/SkCanvasWidget.cpp View 2 chunks +3 lines, -10 lines 0 comments Download
M debugger/QT/SkGLWidget.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M debugger/QT/SkGLWidget.cpp View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M debugger/QT/SkRasterWidget.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M debugger/QT/SkRasterWidget.cpp View 1 2 chunks +3 lines, -7 lines 0 comments Download
M debugger/SkDebugCanvas.h View 1 2 3 4 chunks +7 lines, -23 lines 0 comments Download
M debugger/SkDebugCanvas.cpp View 1 2 3 3 chunks +50 lines, -35 lines 0 comments Download
M debugger/SkDrawCommand.h View 1 chunk +7 lines, -2 lines 0 comments Download
D debugger/SkHitBox.h View 1 chunk +0 lines, -81 lines 0 comments Download
D debugger/SkHitBox.cpp View 1 chunk +0 lines, -66 lines 0 comments Download
M gyp/debugger.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5
chudy
11 years, 11 months ago (2012-07-31 17:36:28 UTC) #1
DerekS
https://codereview.appspot.com/6443068/diff/8001/debugger/SkDebugCanvas.h File debugger/SkDebugCanvas.h (right): https://codereview.appspot.com/6443068/diff/8001/debugger/SkDebugCanvas.h#newcode50 debugger/SkDebugCanvas.h:50: int getLayerAtPoint(int x, int y, int index, SkIPoint transform, ...
11 years, 11 months ago (2012-07-31 17:51:38 UTC) #2
chudy
https://codereview.appspot.com/6443068/diff/8001/debugger/SkDebugCanvas.h File debugger/SkDebugCanvas.h (right): https://codereview.appspot.com/6443068/diff/8001/debugger/SkDebugCanvas.h#newcode50 debugger/SkDebugCanvas.h:50: int getLayerAtPoint(int x, int y, int index, SkIPoint transform, ...
11 years, 11 months ago (2012-07-31 18:00:50 UTC) #3
DerekS
lgtm
11 years, 11 months ago (2012-07-31 19:12:02 UTC) #4
chudy
11 years, 11 months ago (2012-07-31 19:56:39 UTC) #5
Submitted in revision 4867. Thanks for the review
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b