code review 6442080: os: test that IsExist and IsNotExist handle PathError a...

os: test that IsExist and IsNotExist handle PathError and LinkError

[brainman, 2012-08-02 07:12:53]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[r, 2012-08-02 15:30:24]

http://codereview.appspot.com/6442080/diff/4/src/pkg/os/error_plan9.go
File src/pkg/os/error_plan9.go (right):

http://codereview.appspot.com/6442080/diff/4/src/pkg/os/error_plan9.go#newcode14
src/pkg/os/error_plan9.go:14: if pe, ok := err.(*LinkError); ok {
anticipating what might yet arrive, i'd move to type switches now.

switch pe := err.(type) {
case *PathError:
  err = pe.Err
case *LinkError:
  err = pe.Err
}

[brainman, 2012-08-03 02:10:34]

Hello golang-dev@googlegroups.com, r@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[brainman, 2012-08-03 02:10:38]

http://codereview.appspot.com/6442080/diff/4/src/pkg/os/error_plan9.go
File src/pkg/os/error_plan9.go (right):

http://codereview.appspot.com/6442080/diff/4/src/pkg/os/error_plan9.go#newcode14
src/pkg/os/error_plan9.go:14: if pe, ok := err.(*LinkError); ok {
On 2012/08/02 15:30:24, r wrote:
> anticipating what might yet arrive, i'd move to type switches now.
> 
> switch pe := err.(type) {
> case *PathError:
>   err = pe.Err
> case *LinkError:
>   err = pe.Err
> }

Done.

[r, 2012-08-03 04:06:30]

LGTM
put in a nil case for the t.err and submit

http://codereview.appspot.com/6442080/diff/8001/src/pkg/os/error_test.go
File src/pkg/os/error_test.go (right):

http://codereview.appspot.com/6442080/diff/8001/src/pkg/os/error_test.go#newc...
src/pkg/os/error_test.go:95: {&os.LinkError{Err: os.ErrNotExist}, false, true},
you might as well put a nil case in here.

[brainman, 2012-08-03 04:25:43]

*** Submitted as http://code.google.com/p/go/source/detail?r=32eb6dac3ff4 ***

os: test that IsExist and IsNotExist handle PathError and LinkError

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/6442080

http://codereview.appspot.com/6442080/diff/8001/src/pkg/os/error_test.go
File src/pkg/os/error_test.go (right):

http://codereview.appspot.com/6442080/diff/8001/src/pkg/os/error_test.go#newc...
src/pkg/os/error_test.go:95: {&os.LinkError{Err: os.ErrNotExist}, false, true},
On 2012/08/03 04:06:31, r wrote:
> you might as well put a nil case in here.

Done.