Issue 6442055: Skia Debugger can now save modified pictures.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6442055: Skia Debugger can now save modified pictures. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by chudy

Modified:
12 years, 4 months ago

Reviewers:
DerekS

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Skia Debugger can now save modified pictures.

Patch Set 1 : Skia Debugger can now save modified pictures #

Total comments: 2

Patch Set 2 : Addressed Patch 1 Comments #

Patch Set 3 : Fixing merge conflicts #

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+106 lines, -43 lines)			Patch
M	debugger/QT/SkDebuggerGUI.h	View	1 2	4 chunks	+18 lines, -1 line	0 comments	Download
M	debugger/QT/SkDebuggerGUI.cpp	View	1 2	9 chunks	+43 lines, -3 lines	0 comments	Download
M	debugger/QT/moc_SkDebuggerGUI.cpp	View		5 chunks	+42 lines, -38 lines	0 comments	Download
M	debugger/SkDebugCanvas.cpp	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

DerekS

small nit but lgtm http://codereview.appspot.com/6442055/diff/2001/debugger/QT/SkDebuggerGUI.cpp File debugger/QT/SkDebuggerGUI.cpp (right): http://codereview.appspot.com/6442055/diff/2001/debugger/QT/SkDebuggerGUI.cpp#newcode209 debugger/QT/SkDebuggerGUI.cpp:209: filename.append(".skp"); should you only append ...

12 years, 4 months ago (2012-07-27 13:45:28 UTC) #2

chudy

12 years, 4 months ago (2012-07-28 20:17:35 UTC) #3

Fixed and committed at revision 4821. Thanks for the review.

https://codereview.appspot.com/6442055/diff/2001/debugger/QT/SkDebuggerGUI.cpp
File debugger/QT/SkDebuggerGUI.cpp (right):

https://codereview.appspot.com/6442055/diff/2001/debugger/QT/SkDebuggerGUI.cp...
debugger/QT/SkDebuggerGUI.cpp:209: filename.append(".skp");
On 2012/07/27 13:45:28, DerekS wrote:
> should you only append skp if it isn't already there.

Done.

Expand All Messages | Collapse All Messages