Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1455)

Issue 6441157: engine: delay D-Bus name request after factory creation (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by Daiki Ueno
Modified:
11 years, 7 months ago
Reviewers:
shawn.p.huang
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.

Description

engine: delay D-Bus name request after factory creation BUG=none

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -10 lines) Patch
M engine/main.vala View 2 chunks +10 lines, -10 lines 0 comments Download
M src/tests/ibus-bus.c View 2 chunks +18 lines, -0 lines 4 comments Download

Messages

Total messages: 3
Daiki Ueno
I added a simple test for global-engine (see ibus-bus.c in the CL) and noticed that ...
11 years, 7 months ago (2012-08-17 09:10:23 UTC) #1
Peng
lgtm except two style issues. https://codereview.appspot.com/6441157/diff/1/src/tests/ibus-bus.c File src/tests/ibus-bus.c (right): https://codereview.appspot.com/6441157/diff/1/src/tests/ibus-bus.c#newcode634 src/tests/ibus-bus.c:634: g_assert_cmpstr (ibus_engine_desc_get_name (engine_desc), ==, ...
11 years, 7 months ago (2012-08-17 17:51:45 UTC) #2
Daiki Ueno
11 years, 7 months ago (2012-08-20 01:00:04 UTC) #3
https://codereview.appspot.com/6441157/diff/1/src/tests/ibus-bus.c
File src/tests/ibus-bus.c (right):

https://codereview.appspot.com/6441157/diff/1/src/tests/ibus-bus.c#newcode634
src/tests/ibus-bus.c:634: g_assert_cmpstr (ibus_engine_desc_get_name
(engine_desc), ==, "xkb:us::eng");
On 2012/08/17 17:51:45, Peng wrote:
> Is it more than 80 chars.? 

Done.

https://codereview.appspot.com/6441157/diff/1/src/tests/ibus-bus.c#newcode638
src/tests/ibus-bus.c:638: g_assert_cmpstr (ibus_engine_desc_get_name
(engine_desc), ==, "xkb:jp::jpn");
On 2012/08/17 17:51:45, Peng wrote:
> Same

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b