Issue 6441157: engine: delay D-Bus name request after factory creation

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6441157: engine: delay D-Bus name request after factory creation (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by Daiki Ueno

Modified:
12 years, 3 months ago

Reviewers:
shawn.p.huang

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

engine: delay D-Bus name request after factory creation BUG=none

Patch Set 1 #

Total comments: 4

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -10 lines)			Patch
	M	engine/main.vala	View		2 chunks	+10 lines, -10 lines	0 comments	Download
	M	src/tests/ibus-bus.c	View		2 chunks	+18 lines, -0 lines	4 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Daiki Ueno

I added a simple test for global-engine (see ibus-bus.c in the CL) and noticed that ...

12 years, 3 months ago (2012-08-17 09:10:23 UTC) #1

Peng

lgtm except two style issues. https://codereview.appspot.com/6441157/diff/1/src/tests/ibus-bus.c File src/tests/ibus-bus.c (right): https://codereview.appspot.com/6441157/diff/1/src/tests/ibus-bus.c#newcode634 src/tests/ibus-bus.c:634: g_assert_cmpstr (ibus_engine_desc_get_name (engine_desc), ==, ...

12 years, 3 months ago (2012-08-17 17:51:45 UTC) #2

Daiki Ueno

12 years, 3 months ago (2012-08-20 01:00:04 UTC) #3

https://codereview.appspot.com/6441157/diff/1/src/tests/ibus-bus.c
File src/tests/ibus-bus.c (right):

https://codereview.appspot.com/6441157/diff/1/src/tests/ibus-bus.c#newcode634
src/tests/ibus-bus.c:634: g_assert_cmpstr (ibus_engine_desc_get_name
(engine_desc), ==, "xkb:us::eng");
On 2012/08/17 17:51:45, Peng wrote:
> Is it more than 80 chars.? 

Done.

https://codereview.appspot.com/6441157/diff/1/src/tests/ibus-bus.c#newcode638
src/tests/ibus-bus.c:638: g_assert_cmpstr (ibus_engine_desc_get_name
(engine_desc), ==, "xkb:jp::jpn");
On 2012/08/17 17:51:45, Peng wrote:
> Same

Done.

Expand All Messages | Collapse All Messages