Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1266)

Issue 6441115: notify the surface when the canvas draws into it (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 9 months ago by reed1
Modified:
11 years, 4 months ago
CC:
skia-review_googlegroups.com, rmistry
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Add caching of the snapshot image form a surface Notify the surface when the canvas draws into it, so it can invalidate the cached image, and (if needed) perform a copy-on-write on the surface if it was being shared with the image. Committed: https://code.google.com/p/skia/source/detail?r=5306

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+220 lines, -34 lines) Patch
M gm/image.cpp View 1 2 2 chunks +11 lines, -0 lines 0 comments Download
M gyp/core.gyp View 1 2 1 chunk +1 line, -0 lines 1 comment Download
M gyp/core.gypi View 1 2 1 chunk +13 lines, -0 lines 0 comments Download
M gyp/gmslides.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkCanvas.h View 1 2 3 chunks +12 lines, -0 lines 0 comments Download
M include/core/SkDevice.h View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M include/core/SkImage.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkSurface.h View 1 2 3 chunks +10 lines, -5 lines 0 comments Download
M src/core/SkCanvas.cpp View 1 2 6 chunks +13 lines, -0 lines 0 comments Download
M src/core/SkDevice.cpp View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M src/core/SkPictureRecord.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/image/SkImage.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/image/SkImagePriv.h View 1 2 2 chunks +15 lines, -2 lines 0 comments Download
M src/image/SkImagePriv.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M src/image/SkImage_Raster.cpp View 1 2 3 chunks +6 lines, -2 lines 0 comments Download
M src/image/SkSurface.cpp View 1 2 3 chunks +80 lines, -5 lines 0 comments Download
M src/image/SkSurface_Base.h View 1 2 1 chunk +19 lines, -8 lines 0 comments Download
M src/image/SkSurface_Raster.cpp View 1 2 4 chunks +20 lines, -8 lines 0 comments Download

Messages

Total messages: 4
reed1
70% ready to commit...
11 years, 9 months ago (2012-08-08 17:35:11 UTC) #1
reed1
ready to commit, so others can help finish (e.g. gpu backend). Should not get exercised ...
11 years, 8 months ago (2012-08-27 21:02:48 UTC) #2
epoger
https://codereview.appspot.com/6441115/diff/6001/gyp/core.gyp File gyp/core.gyp (right): https://codereview.appspot.com/6441115/diff/6001/gyp/core.gyp#newcode20 gyp/core.gyp:20: '../src/image', So our "core" package now depends on code ...
11 years, 4 months ago (2013-01-02 18:54:52 UTC) #3
epoger
11 years, 4 months ago (2013-01-02 19:53:47 UTC) #4
Message was sent while issue was closed.
On 2013/01/02 18:54:52, epoger wrote:
> https://codereview.appspot.com/6441115/diff/6001/gyp/core.gyp
> File gyp/core.gyp (right):
> 
> https://codereview.appspot.com/6441115/diff/6001/gyp/core.gyp#newcode20
> gyp/core.gyp:20: '../src/image',
> So our "core" package now depends on code within the "image" package?  This
> breaks our current method of importing our code into google3/...

It turns out that it's not as dire as my comment indicates.

This doesn't really break our method of importing Skia into google3/third_party.
 What it *does* do is effectively make "core" depend on "image", even though
that dependency is not expressed in core.gyp.  So our google3/third_party BUILD
file now needs to build "image", when it didn't before.

From discussion with Mike, it sounds like that will be OK.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b