Issue 6441070: Fixed numerous mem errors

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6441070: Fixed numerous mem errors (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by chudy

Modified:
12 years, 4 months ago

Reviewers:
DerekS

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Fixed numerous mem errors Committed: https://code.google.com/p/skia/source/detail?r=4849

Patch Set 1 : Fixed memory errors due to instantiation and destruction sequence ordering #

Total comments: 4

Patch Set 2 : Addressed patch 1 comments #

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -50 lines)			Patch
M	debugger/QT/SkCanvasWidget.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	debugger/QT/SkCanvasWidget.cpp	View		2 chunks	+7 lines, -3 lines	0 comments	Download
M	debugger/QT/SkDebuggerGUI.h	View		4 chunks	+7 lines, -5 lines	0 comments	Download
M	debugger/QT/SkDebuggerGUI.cpp	View		4 chunks	+5 lines, -10 lines	0 comments	Download
M	debugger/QT/SkGLWidget.h	View	1	2 chunks	+1 line, -2 lines	0 comments	Download
M	debugger/QT/SkGLWidget.cpp	View	1	1 chunk	+4 lines, -1 line	0 comments	Download
M	debugger/QT/SkInspectorWidget.h	View		1 chunk	+1 line, -3 lines	0 comments	Download
M	debugger/QT/SkInspectorWidget.cpp	View		2 chunks	+1 line, -4 lines	0 comments	Download
M	debugger/QT/SkRasterWidget.cpp	View		1 chunk	+7 lines, -8 lines	0 comments	Download
M	debugger/QT/SkSettingsWidget.h	View		3 chunks	+6 lines, -7 lines	0 comments	Download
M	debugger/QT/SkSettingsWidget.cpp	View		4 chunks	+2 lines, -5 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

DerekS

https://codereview.appspot.com/6441070/diff/4001/debugger/QT/SkGLWidget.cpp File debugger/QT/SkGLWidget.cpp (right): https://codereview.appspot.com/6441070/diff/4001/debugger/QT/SkGLWidget.cpp#newcode13 debugger/QT/SkGLWidget.cpp:13: , fInitialized(false) no need to have this variable, but ...

12 years, 4 months ago (2012-07-30 20:42:15 UTC) #2

chudy

12 years, 4 months ago (2012-07-30 20:46:59 UTC) #3

DerekS

12 years, 4 months ago (2012-07-30 20:52:25 UTC) #4

lgtm. hold off on the commit until bungeman's rebaseline goes through.

Expand All Messages | Collapse All Messages