Issue 6441057: Mac build fix after gradient restructure/renaming.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6441057: Mac build fix after gradient restructure/renaming. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by rileya

Modified:
12 years, 3 months ago

Reviewers:
reed1, bsalomon, robertphillips, TomH

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Mac build fix after gradient restructure/renaming. Committed: https://code.google.com/p/skia/source/detail?r=4797

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+48 lines, -48 lines)			Patch
M	src/animator/SkDisplayType.h	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/animator/SkDisplayType.cpp	View	9 chunks	+9 lines, -9 lines	0 comments	Download
M	src/animator/SkDrawColor.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/animator/SkDrawColor.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/animator/SkDrawGradient.h	View	4 chunks	+12 lines, -12 lines	0 comments	Download
M	src/animator/SkDrawGradient.cpp	View	10 chunks	+22 lines, -22 lines	0 comments	Download

Total messages: 3

rileya

Turns out there were already classes named "SkLinearGradient" and "SkRadialGradient" in animator... though there's nowhere ...

12 years, 3 months ago (2012-07-26 21:05:20 UTC) #1

LGTM, but I defer to Mike.