Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1560)

Unified Diff: src/gpu/effects/GrGradientEffects.cpp

Issue 6440046: Move filter/wrap out of GrSamplerState into GrTextureParams (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: rename kFilterDefault to kBilerpDefault Created 12 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/gpu/SkGr.cpp ('k') | src/gpu/gl/GrGLTexture.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/gpu/effects/GrGradientEffects.cpp
===================================================================
--- src/gpu/effects/GrGradientEffects.cpp (revision 4752)
+++ src/gpu/effects/GrGradientEffects.cpp (working copy)
@@ -62,14 +62,12 @@
SkBitmap bitmap;
shader.asABitmap(&bitmap, NULL, NULL, NULL);
- // Note: we just construct a default sampler state here, which isn't great,
+ // Note: we pass NULL for the texture params here, which isn't great,
// however, as long as the bitmap has power-of-two dimensions, which should
- // be the case for gradient bitmaps, it should be fine
+ // be the case for gradient bitmaps, it should be fine.
+ // TODO: Determine the texture params here and pass them in.
GrAssert(SkIsPow2(bitmap.width()) && SkIsPow2(bitmap.height()));
- GrSamplerState sampler;
-
- GrContext::TextureCacheEntry entry = GrLockCachedBitmapTexture(ctx, bitmap,
- &sampler);
+ GrContext::TextureCacheEntry entry = GrLockCachedBitmapTexture(ctx, bitmap, NULL);
fTexture = entry.texture();
SkSafeRef(fTexture);
fUseTexture = true;
« no previous file with comments | « src/gpu/SkGr.cpp ('k') | src/gpu/gl/GrGLTexture.h » ('j') | no next file with comments »

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b