Issue 6438044: SkTextBox to use public interfaces for line layout.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6438044: SkTextBox to use public interfaces for line layout. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by bungeman

Modified:
12 years, 4 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 2 : Better way of doing it. #

Patch Set 3 : Remove unused include. #

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -48 lines)			Patch
	M	src/views/SkTextBox.cpp	View	1 2	3 chunks	+1 line, -48 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

bungeman

SkTextBox is used by SampleApp. Its use of internal interfaces is getting in the way ...

12 years, 4 months ago (2012-07-24 15:06:26 UTC) #1

bungeman

Will try to come up with something more correct. https://codereview.appspot.com/6438044/diff/1/src/views/SkTextBox.cpp File src/views/SkTextBox.cpp (right): https://codereview.appspot.com/6438044/diff/1/src/views/SkTextBox.cpp#newcode34 src/views/SkTextBox.cpp:34: ...

12 years, 4 months ago (2012-07-24 15:15:25 UTC) #2

bungeman

Looks like the first time I missed the forest for the trees.

12 years, 4 months ago (2012-07-24 15:44:06 UTC) #3

Committed revision 4731.

Expand All Messages | Collapse All Messages