Issue 6434049: Split SkGlyph into its own header.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6434049: Split SkGlyph into its own header. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by bungeman

Modified:
11 years, 11 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 1 #

Total comments: 1

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+157 lines, -139 lines)			Patch
M	gyp/core.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	include/core/SkAutoKern.h	View	1 chunk	+1 line, -1 line	0 comments	Download
A	include/core/SkGlyph.h	View	1 chunk	+150 lines, -0 lines	1 comment	Download
M	include/core/SkScalerContext.h	View	2 chunks	+2 lines, -138 lines	0 comments	Download
M	src/core/SkGlyphCache.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/ports/SkFontHost_FreeType.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/ports/SkFontHost_mac_coretext.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bungeman

The reason for this is so that SkAutoKern can include just SkGlyph without pulling in ...

11 years, 11 months ago (2012-07-24 19:23:13 UTC) #1

reed1

lgtm can we make SkGlyph private eventually? https://codereview.appspot.com/6434049/diff/1/include/core/SkGlyph.h File include/core/SkGlyph.h (right): https://codereview.appspot.com/6434049/diff/1/include/core/SkGlyph.h#newcode16 include/core/SkGlyph.h:16: TODO in ...

11 years, 11 months ago (2012-07-24 19:25:20 UTC) #2

bungeman

11 years, 11 months ago (2012-07-24 20:36:51 UTC) #3

Committed revision 4741.

It would be nice to make SkGlyph.h private, I think the only thing we would need
to do is put the implementation of SkAutoKern::adjust into a .cpp. Then SkGlyph
can just be forward declared in SkAutoKern.h.

There aren't many users of the constants, it would be nice to put them in a
better place.

Expand All Messages | Collapse All Messages