Issue 6430052: Fix SK_OVERRIDE for various versions of clang

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6430052: Fix SK_OVERRIDE for various versions of clang (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by gw280

Modified:
12 years, 5 months ago

Reviewers:
epoger, TomH

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Fix SK_OVERRIDE for various versions of clang BUG= TEST= Committed: https://code.google.com/p/skia/source/detail?r=4765

Patch Set 1 #

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	include/core/SkPostConfig.h	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

gw280

Original mozilla bug: https://bugzilla.mozilla.org/show_bug.cgi?id=731384

12 years, 6 months ago (2012-07-20 15:34:23 UTC) #2

epoger

LGTM Hey, if it works, I'm all for it. Maybe indent to make it easier ...

12 years, 6 months ago (2012-07-20 15:42:28 UTC) #3

gw280

12 years, 5 months ago (2012-07-25 19:06:39 UTC) #5

On 2012/07/20 15:42:28, epoger wrote:
> Hey, if it works, I'm all for it.
> Maybe indent to make it easier to follow the if/else blocks?

Committed with the indentation fixed

Expand All Messages | Collapse All Messages