code review 6430043: otr: support signaling the end of a conversation.

otr: support signaling the end of a conversation.

The explicit OTR termination signal tells the peer that they should
discard their session keys and, more importantly, tells them that
*you* have done so and therefore cannot decrypt future messages.

[agl1, 2012-07-18 15:08:11]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go.crypto

[r, 2012-07-18 15:50:18]

http://codereview.appspot.com/6430043/diff/7001/otr/otr.go
File otr/otr.go (right):

http://codereview.appspot.com/6430043/diff/7001/otr/otr.go#newcode55
otr/otr.go:55: // ErrorPrefix can be prepended to an error message to make it an
OTR error.
prepended is not a word.
maybe prefixed, or rewrite.

http://codereview.appspot.com/6430043/diff/7001/otr/otr.go#newcode504
otr/otr.go:504: c.state = statePlaintext
shouldn't there be a return here?

[agl1, 2012-07-18 17:32:33]

http://codereview.appspot.com/6430043/diff/7001/otr/otr.go
File otr/otr.go (right):

http://codereview.appspot.com/6430043/diff/7001/otr/otr.go#newcode55
otr/otr.go:55: // ErrorPrefix can be prepended to an error message to make it an
OTR error.
On 2012/07/18 15:50:18, r wrote:
> prepended is not a word.
> maybe prefixed, or rewrite.

I hope prepend makes it into the dictionary soon because it's much nicer than
wringing a verb out of `prefix'.

I've rewritten to avoid using it however. Now:

// ErrorPrefix can be used to make an OTR error by appending an error message 
// to it.

http://codereview.appspot.com/6430043/diff/7001/otr/otr.go#newcode504
otr/otr.go:504: c.state = statePlaintext
On 2012/07/18 15:50:18, r wrote:
> shouldn't there be a return here?

Good catch, thanks!

[r, 2012-07-18 21:14:35]

LGTM

[agl1, 2012-07-24 23:22:10]

*** Submitted as
http://code.google.com/p/go/source/detail?r=cff3f3cc78cd&repo=crypto ***

otr: support signaling the end of a conversation.

The explicit OTR termination signal tells the peer that they should
discard their session keys and, more importantly, tells them that
*you* have done so and therefore cannot decrypt future messages.

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/6430043