Added an option to specify the tiling size to render_pictures.

Added an option to specify the tiling size to render_pictures.

With this change I should be able to start merging the rendering implementations of bench_pictures and render_pictures.

Committed https://code.google.com/p/skia/source/detail?r=4816

[junov1, 2012-07-23 17:33:49]

https://codereview.appspot.com/6427061/diff/1/tools/render_pictures_main.cpp
File tools/render_pictures_main.cpp (right):

https://codereview.appspot.com/6427061/diff/1/tools/render_pictures_main.cpp#...
tools/render_pictures_main.cpp:34: void (*fRenderFunc) (SkPicture* pict,
SkBitmap* bitmap, const Options& options);
Struct with func ptrs are old school.  An object-oriented design would be
cleaner and easier to maintain.  Something like.

class PictureRenderer : public SkRefCnt {
public:
    virtual void init() {}
    virtual void render(SkPicture* pict, SkBitmap* bitmap) = 0;
};

class TiledPictureRenderer {
public:
    TiledPictureRenderer(char** &argv, char** stop) {
        // code that pares the args of --tile
        (...)
    }
    
    virtual void init() {
        // calculate tile size and setup tiles
        (...)
    }
    virtual void render(SkPicture* pict, SkBitmap* bitmap) {
        // Do the tile rendering
    }
private:
    int fTileWidth;
    int fTileHeight;
    double fTileWidthPercentage;
    double fTileHeightPercentage;
};

In parse_commandline, you would have something like this:

if (0 == strcmp(*argv, "--tile")) {
    SkRefCnt_SafeAssign( pictureRenderer, new TiledPictureRenderer(++argv,
stop));
    pictureRenderer->unref();
}

[keyar, 2012-07-27 15:29:12]

This patch is updated to reflect that render_pictures now uses classes to hold
the rendering method.

[junov1, 2012-07-27 19:46:20]

On 2012/07/27 15:29:12, keyar wrote:
> This patch is updated to reflect that render_pictures now uses classes to hold
> the rendering method.

lgtm