Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(199)

Issue 6426047: code review 6426047: net: add read, write message methods to IPConn, UDPConn (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 4 months ago by mikio
Modified:
10 years, 2 months ago
Reviewers:
CC:
rsc, r, dfc, golang-dev
Visibility:
Public.

Description

net: add read, write message methods to IPConn, UDPConn Both methods allow to access the IP ancillary data through socket control messages. This CL is required for CL 6482044; go.net/ipv4: new package.

Patch Set 1 : diff -r b42e90a3d42f https://code.google.com/p/go #

Patch Set 2 : diff -r 4e3a1967af09 https://code.google.com/p/go #

Patch Set 3 : diff -r 62f087306b18 https://code.google.com/p/go #

Patch Set 4 : diff -r 62f087306b18 https://code.google.com/p/go #

Patch Set 5 : diff -r 1e84edee3397 https://code.google.com/p/go #

Total comments: 3

Patch Set 6 : diff -r 3181682928c9 https://code.google.com/p/go #

Total comments: 8

Patch Set 7 : diff -r 979c5e5b1308 https://code.google.com/p/go #

Patch Set 8 : diff -r c09350860e11 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -0 lines) Patch
M src/pkg/net/iprawsock_posix.go View 1 2 3 4 5 6 2 chunks +33 lines, -0 lines 0 comments Download
M src/pkg/net/udpsock_posix.go View 1 2 3 4 5 6 2 chunks +37 lines, -0 lines 0 comments Download

Messages

Total messages: 20
mikio
Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
10 years, 4 months ago (2012-08-03 11:20:56 UTC) #1
rsc
I am sorry for being so uninformed, but how can an IP packet have out-of-band ...
10 years, 4 months ago (2012-08-03 19:49:44 UTC) #2
mikio
On Sat, Aug 4, 2012 at 4:49 AM, Russ Cox <rsc@golang.org> wrote: > I am ...
10 years, 4 months ago (2012-08-07 03:25:22 UTC) #3
r
There's a typo in the CL description. That's the most intelligent thing I have to ...
10 years, 4 months ago (2012-08-07 03:46:26 UTC) #4
mikio
Hello rsc@golang.org, r@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
10 years, 4 months ago (2012-08-10 12:39:21 UTC) #5
mikio
Hello rsc@golang.org, r@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
10 years, 3 months ago (2012-08-21 16:01:18 UTC) #6
dfc
Thank you for this proposal. I'm not wild about the use of named return arguments, ...
10 years, 3 months ago (2012-08-22 00:04:42 UTC) #7
mikio
all done.
10 years, 3 months ago (2012-08-28 03:21:17 UTC) #8
mikio
Hello rsc@golang.org, r@golang.org, dave@cheney.net (cc: golang-dev@googlegroups.com), Please take another look.
10 years, 3 months ago (2012-08-28 03:24:36 UTC) #9
dfc
On 2012/08/28 03:24:36, mikio wrote: > Hello mailto:rsc@golang.org, mailto:r@golang.org, mailto:dave@cheney.net (cc: > mailto:golang-dev@googlegroups.com), > > ...
10 years, 3 months ago (2012-09-03 11:33:40 UTC) #10
dfc
http://codereview.appspot.com/6426047/diff/37001/src/pkg/net/iprawsock_posix.go File src/pkg/net/iprawsock_posix.go (right): http://codereview.appspot.com/6426047/diff/37001/src/pkg/net/iprawsock_posix.go#newcode146 src/pkg/net/iprawsock_posix.go:146: func (c *IPConn) WriteMsgIP(b, oob []byte, addr *IPAddr) (n, ...
10 years, 3 months ago (2012-09-03 11:33:49 UTC) #11
mikio
On 2012/09/03 11:33:49, dfc wrote: > http://codereview.appspot.com/6426047/diff/37001/src/pkg/net/iprawsock_posix.go#newcode146 > src/pkg/net/iprawsock_posix.go:146: func (c *IPConn) WriteMsgIP(b, oob []byte, ...
10 years, 3 months ago (2012-09-07 08:10:21 UTC) #12
dfc
LGTM. As this is an addition to the public API, I suggest waiting for one ...
10 years, 3 months ago (2012-09-07 09:22:54 UTC) #13
mikio
anyone? On Fri, Sep 7, 2012 at 6:22 PM, <dave@cheney.net> wrote: > LGTM. As this ...
10 years, 3 months ago (2012-09-07 23:49:30 UTC) #14
dfc
ping. Are there any Authors who can approve the additions to the net pkg API.
10 years, 2 months ago (2012-09-10 23:49:59 UTC) #15
rsc
The new functions are fine. The changes to the existing functions I don't quite understand ...
10 years, 2 months ago (2012-09-11 01:02:51 UTC) #16
mikio
On 2012/09/11 01:02:51, rsc wrote: > http://codereview.appspot.com/6426047/diff/37001/src/pkg/net/iprawsock_posix.go#newcode79 > src/pkg/net/iprawsock_posix.go:79: if addr.IP.To4() != nil && len(b) ...
10 years, 2 months ago (2012-09-18 17:33:16 UTC) #17
mikio
Hello rsc@golang.org, r@golang.org, dave@cheney.net (cc: golang-dev@googlegroups.com), Please take another look.
10 years, 2 months ago (2012-09-18 17:33:38 UTC) #18
rsc
LGTM
10 years, 2 months ago (2012-09-24 15:04:43 UTC) #19
mikio
10 years, 2 months ago (2012-09-24 21:57:38 UTC) #20
*** Submitted as http://code.google.com/p/go/source/detail?r=96fde1b15506 ***

net: add read, write message methods to IPConn, UDPConn

Both methods allow to access the IP ancillary data through
socket control messages.

This CL is required for CL 6482044; go.net/ipv4: new package.

R=rsc, r, dave
CC=golang-dev
http://codereview.appspot.com/6426047
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b