Issue 6426046: Adding virtual overload of isDrawingToLayer() to SkGPipe

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6426046: Adding virtual overload of isDrawingToLayer() to SkGPipe (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by junov1

Modified:
12 years, 3 months ago

Reviewers:
Leon, reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Adding virtual overload of isDrawingToLayer() to SkGPipe This change is to make The SkGPipe port of SkDeferredCanvas pass the CanvasTest unit test Committed: https://code.google.com/p/skia/source/detail?r=4661

Patch Set 1 #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -1 line)			Patch
	M	src/pipe/SkGPipeWrite.cpp	View		5 chunks	+19 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

reed1

What is the non-unittest use for isDrawingToLayer()? Does that use-case also want us to make ...

12 years, 3 months ago (2012-07-18 20:32:55 UTC) #3

junov1

12 years, 3 months ago (2012-07-18 20:37:25 UTC) #4

IIRC there is code in webkit and chromium to disable LCD text AA when
isDrawingToLayer() returns true.  The fact that canvas rendering is deferred or
not should be transparent to that code.

Expand All Messages | Collapse All Messages