Issue 6423065: code review 6423065: go.crypto/ssh: improve TestServerWindow robustness

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6423065: code review 6423065: go.crypto/ssh: improve TestServerWindow robustness (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 3 months ago by dave

Modified:
14 years, 3 months ago

Reviewers:

CC:
agl1, gpaul, kardia, golang-dev

Visibility:
Public.

Description

go.crypto/ssh: improve TestServerWindow robustness Fix a few resource leaks and prevent the test from hanging if an error occurs reading from the remote server.

Patch Set 1 #

Patch Set 2 : diff -r 86bed5e91c9d https://code.google.com/p/go.crypto #

Patch Set 3 : diff -r 86bed5e91c9d https://code.google.com/p/go.crypto #

Patch Set 4 : diff -r 86bed5e91c9d https://code.google.com/p/go.crypto #

Created: 14 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -8 lines)			Patch
	M	ssh/server_test.go	View	1 2	6 chunks	+7 lines, -8 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

dave_cheney.net

Hello agl@golang.org, gustav.paul@gmail.com, kardianos@gmail.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.crypto

14 years, 3 months ago (2012-07-20 12:23:20 UTC) #1

dave_cheney.net

14 years, 3 months ago (2012-07-21 04:19:39 UTC) #5

*** Submitted as
http://code.google.com/p/go/source/detail?r=ff6d5d46978d&repo=crypto ***

go.crypto/ssh: improve TestServerWindow robustness

Fix a few resource leaks and prevent the test from
hanging if an error occurs reading from the remote
server.

R=agl, gustav.paul, kardianos
CC=golang-dev
http://codereview.appspot.com/6423065

Expand All Messages | Collapse All Messages