Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(730)

Issue 6421061: replace src/application usage of RandomVariable with RandomVariableStream

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 11 months ago by Tom Henderson
Modified:
9 years, 11 months ago
Reviewers:
Vedran Miletić
CC:
ns-3-reviews_googlegroups.com
Visibility:
Public.

Description

replace src/application usage of RandomVariable with RandomVariableStream

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+216 lines, -153 lines) Patch
M examples/error-model/simple-error-model.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/routing/dynamic-global-routing.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M examples/routing/global-injection-slash32.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/routing/global-routing-slash32.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/routing/mixed-global-routing.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/routing/simple-alternate-routing.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/routing/simple-global-routing.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/routing/static-routing-slash32.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/tcp/star.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/tcp/tcp-star-server.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M examples/wireless/mixed-wireless.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/wireless/multirate.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/wireless/wifi-ap.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M examples/wireless/wifi-wired-bridging.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/aodv/test/bug-772.cc View 2 chunks +4 lines, -3 lines 1 comment Download
M src/applications/helper/on-off-helper.h View 2 chunks +14 lines, -0 lines 0 comments Download
M src/applications/helper/on-off-helper.cc View 2 chunks +21 lines, -0 lines 0 comments Download
M src/applications/model/bulk-send-application.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/applications/model/onoff-application.h View 3 chunks +13 lines, -4 lines 0 comments Download
M src/applications/model/onoff-application.cc View 6 chunks +22 lines, -11 lines 0 comments Download
M src/applications/model/radvd.h View 3 chunks +16 lines, -0 lines 0 comments Download
M src/applications/model/radvd.cc View 6 chunks +17 lines, -5 lines 0 comments Download
M src/bridge/examples/csma-bridge.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/bridge/examples/csma-bridge-one-hop.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/csma/examples/csma-broadcast.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/csma/examples/csma-multicast.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/csma/examples/csma-one-subnet.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/csma/examples/csma-packet-socket.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M src/csma/examples/csma-ping.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/csma/examples/csma-raw-ip-socket.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/netanim/examples/dumbbell-animation.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M src/netanim/examples/grid-animation.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M src/netanim/examples/star-animation.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/network/examples/red-tests.cc View 6 chunks +12 lines, -24 lines 0 comments Download
M src/olsr/examples/simple-point-to-point-olsr.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/spectrum/examples/adhoc-aloha-ideal-phy.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/spectrum/examples/adhoc-aloha-ideal-phy-matrix-propagation-loss-model.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/spectrum/examples/adhoc-aloha-ideal-phy-with-microwave-oven.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/spectrum/test/spectrum-ideal-phy-test.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M src/test/csma-system-test-suite.cc View 10 chunks +17 lines, -18 lines 0 comments Download
M src/test/global-routing-test-suite.cc View 4 chunks +6 lines, -7 lines 0 comments Download
M src/test/ns3wifi/wifi-msdu-aggregator-test-suite.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/test/static-routing-test-suite.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M src/uan/examples/uan-cw-example.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/uan/examples/uan-rc-example.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/virtual-net-device/examples/virtual-net-device.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2
Vedran Miletić
No concerns. +1 http://codereview.appspot.com/6421061/diff/1/src/aodv/test/bug-772.cc File src/aodv/test/bug-772.cc (right): http://codereview.appspot.com/6421061/diff/1/src/aodv/test/bug-772.cc#newcode134 src/aodv/test/bug-772.cc:134: onoff.SetAttribute ("OffTime", StringValue ("ns3::ConstantRandomVariable[Constant=0.0]")); Any reason ...
9 years, 11 months ago (2012-08-04 12:17:32 UTC) #1
Tom Henderson
9 years, 11 months ago (2012-08-07 16:35:52 UTC) #2
On 2012/08/04 12:17:32, Vedran Miletić wrote:
> No concerns.
> 
> +1
> 
> http://codereview.appspot.com/6421061/diff/1/src/aodv/test/bug-772.cc
> File src/aodv/test/bug-772.cc (right):
> 
>
http://codereview.appspot.com/6421061/diff/1/src/aodv/test/bug-772.cc#newcode134
> src/aodv/test/bug-772.cc:134: onoff.SetAttribute ("OffTime", StringValue
> ("ns3::ConstantRandomVariable[Constant=0.0]"));
> Any reason for using 1.0 and 0.0? No hard feelings against it, but I find it
> inconsistent with other examples.

I agree with you to keep it the way it was ('1' and '0'); I'll make that change.

Thanks for reviewing this.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b