Move texture lock/unlock functions from SkGpuDevice into SkGr as global functions, also removed inc…

Move texture lock/unlock functions from SkGpuDevice into SkGr as global functions, also removed inconsistent "SkGr" class.
Committed: https://code.google.com/p/skia/source/detail?r=4664

[bsalomon, 2012-07-18 21:13:44]

Thanks for doing this cleanup! I have a few nits, otherwise LGTM.

https://codereview.appspot.com/6420048/diff/1/include/gpu/SkGr.h
File include/gpu/SkGr.h (right):

https://codereview.appspot.com/6420048/diff/1/include/gpu/SkGr.h#newcode75
include/gpu/SkGr.h:75: GrPixelConfig BitmapConfig2PixelConfig(SkBitmap::Config);
SkBitmapConfig2GrPixelConfig

https://codereview.appspot.com/6420048/diff/1/include/gpu/SkGr.h#newcode88
include/gpu/SkGr.h:88: GrContext::TextureCacheEntry LockCachedTexture(GrContext*
ctx,
Let's call these GrLockCachedBitmapTexture/GrUnlockCachedBitmapTexture since
they are Gr functions and are used with SkBitmaps.

https://codereview.appspot.com/6420048/diff/1/src/gpu/SkGr.cpp
File src/gpu/SkGr.cpp (right):

https://codereview.appspot.com/6420048/diff/1/src/gpu/SkGr.cpp#newcode59
src/gpu/SkGr.cpp:59: GrContext::TextureCacheEntry
sk_gr_create_bitmap_texture(GrContext* ctx,
either static or put this (along with preceding function) in an anonymous
namespace.

[rileya, 2012-07-18 21:35:39]

On 2012/07/18 21:13:44, bsalomon wrote:
> Thanks for doing this cleanup! I have a few nits, otherwise LGTM.
> 
> https://codereview.appspot.com/6420048/diff/1/include/gpu/SkGr.h
> File include/gpu/SkGr.h (right):
> 
> https://codereview.appspot.com/6420048/diff/1/include/gpu/SkGr.h#newcode75
> include/gpu/SkGr.h:75: GrPixelConfig
BitmapConfig2PixelConfig(SkBitmap::Config);
> SkBitmapConfig2GrPixelConfig
> 
> https://codereview.appspot.com/6420048/diff/1/include/gpu/SkGr.h#newcode88
> include/gpu/SkGr.h:88: GrContext::TextureCacheEntry
LockCachedTexture(GrContext*
> ctx,
> Let's call these GrLockCachedBitmapTexture/GrUnlockCachedBitmapTexture since
> they are Gr functions and are used with SkBitmaps.
> 
> https://codereview.appspot.com/6420048/diff/1/src/gpu/SkGr.cpp
> File src/gpu/SkGr.cpp (right):
> 
> https://codereview.appspot.com/6420048/diff/1/src/gpu/SkGr.cpp#newcode59
> src/gpu/SkGr.cpp:59: GrContext::TextureCacheEntry
> sk_gr_create_bitmap_texture(GrContext* ctx,
> either static or put this (along with preceding function) in an anonymous
> namespace.

Wow, I misread those names and updated this incorrectly 3 times in a row... but
now everything's been renamed as suggested, and I made
sk_gr_create_bitmap_texture static.

[bsalomon, 2012-07-18 21:41:40]

One small nit (no need to re-review)

https://codereview.appspot.com/6420048/diff/7002/include/gpu/SkGr.h
File include/gpu/SkGr.h (right):

https://codereview.appspot.com/6420048/diff/7002/include/gpu/SkGr.h#newcode77
include/gpu/SkGr.h:77: inline GrColor SkColor2GrColor(SkColor c) {
static inline