Issue 6419076: Fix Android build for new toolchain

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6419076: Fix Android build for new toolchain (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by EricB

Modified:
12 years, 4 months ago

Reviewers:
DerekS

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Fix Android build for new toolchain The new toolchain (r8b) does not automatically include the necessary directories (http://code.google.com/p/android/issues/detail?id=35279). Add them manually until this is fixed. Committed: https://code.google.com/p/skia/source/detail?r=4749

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -1 line)			Patch
	M	gyp/common_conditions.gypi	View	1 2	1 chunk	+9 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

EricB

http://codereview.appspot.com/6419076/diff/1/gyp/common_conditions.gypi File gyp/common_conditions.gypi (right): http://codereview.appspot.com/6419076/diff/1/gyp/common_conditions.gypi#newcode221 gyp/common_conditions.gypi:221: '<(android_base)/toolchains/<(android_toolchain)/sysroot/usr/include', Ugly and unfortunate. Hopefully it's fixed soon. http://codereview.appspot.com/6419076/diff/1/gyp/common_conditions.gypi#newcode227 ...

12 years, 4 months ago (2012-07-24 21:18:50 UTC) #1

DerekS

lgtm. can you put a comment to the bug that needs fixed before we can ...

12 years, 4 months ago (2012-07-25 15:16:01 UTC) #3

EricB

12 years, 4 months ago (2012-07-25 15:16:54 UTC) #4

On 2012/07/25 15:16:01, DerekS wrote:
> lgtm. can you put a comment to the bug that needs fixed before we can remove
> those include paths.

It's in the CL description, but here it is again:
http://code.google.com/p/android/issues/detail?id=35279

Expand All Messages | Collapse All Messages