Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1454)

Issue 6416049: Adding new steps to Canvas unit test to validate that the deferred (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 5 months ago by junov1
Modified:
12 years, 5 months ago
Reviewers:
Leon
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Adding new steps to Canvas unit test to validate that the deferred canvas state coherence test case passes with sequences of draw commands that trigger flushes and purges of deferred draw commands. This CL confirms that using SkGPipe fixes the deferred canvas issues that are the root problem of crbug.com/133432 BUG=https://code.google.com/p/chromium/issues/detail?id=133432 Committed: https://code.google.com/p/skia/source/detail?r=4687

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -0 lines) Patch
M tests/CanvasTest.cpp View 1 1 chunk +43 lines, -0 lines 2 comments Download

Messages

Total messages: 2
junov1
PTAL
12 years, 5 months ago (2012-07-19 21:21:58 UTC) #1
Leon
12 years, 5 months ago (2012-07-19 21:45:19 UTC) #2
LGTM with spelling fixes.

https://codereview.appspot.com/6416049/diff/2001/tests/CanvasTest.cpp
File tests/CanvasTest.cpp (right):

https://codereview.appspot.com/6416049/diff/2001/tests/CanvasTest.cpp#newcode539
tests/CanvasTest.cpp:539: // that discards previously recorded commands. The
callenge is to maintain
challenge*

https://codereview.appspot.com/6416049/diff/2001/tests/CanvasTest.cpp#newcode561
tests/CanvasTest.cpp:561: // reset the recording session. The callenge is to
maintain correct
challenge*
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b