Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5)

Issue 6415043: Do not call MacroExpander::popMacro() from MacroExpander::~MacroExpander(). (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 8 months ago by Alok Priyadarshi
Modified:
13 years, 8 months ago
Reviewers:
kbr1
CC:
angleproject-review_googlegroups.com, gmanchromium
Base URL:
http://angleproject.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Do not call MacroExpander::popMacro() from MacroExpander::~MacroExpander(). MacroExpander::popMacro() assumes that the macro being popped has been fully parsed. This may not be true for MacroExpander destructor which may get called anytime the compiler decides to abort the compilation process. This patch just deletes the macro-contexts pushed in the stack without validating the parse state of current macro. BUG=348 Committed: https://code.google.com/p/angleproject/source/detail?r=1227

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M src/compiler/preprocessor/new/MacroExpander.cpp View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 4
Alok Priyadarshi
13 years, 8 months ago (2012-07-17 21:20:35 UTC) #1
kbr1
This needs a regression test.
13 years, 8 months ago (2012-07-18 00:08:28 UTC) #2
Alok Priyadarshi
On 2012/07/18 00:08:28, kbr1 wrote: > This needs a regression test. I cannot think of ...
13 years, 8 months ago (2012-07-18 01:46:15 UTC) #3
kbr1
13 years, 8 months ago (2012-07-18 01:56:55 UTC) #4
Unfortunate, but OK -- LGTM.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b