Issue 6409045: skdiff: cap return value at 255 to avoid automatic 'wrapping' (%256) of return value

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6409045: skdiff: cap return value at 255 to avoid automatic 'wrapping' (%256) of return value (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by epoger

Modified:
12 years, 1 month ago

Reviewers:
rmistry

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

skdiff: cap return value at 255 to avoid automatic 'wrapping' (%256) of return value Committed: https://code.google.com/p/skia/source/detail?r=4629

Patch Set 2 : #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	tools/skdiff_main.cpp	View	1	1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rmistry

LGTM https://codereview.appspot.com/6409045/diff/1/tools/skdiff_main.cpp File tools/skdiff_main.cpp (right): https://codereview.appspot.com/6409045/diff/1/tools/skdiff_main.cpp#newcode1317 tools/skdiff_main.cpp:1317: return num_failing_results; [optional] return (num_failing_results > 255) ? ...

12 years, 1 month ago (2012-07-16 17:56:45 UTC) #2

epoger

12 years, 1 month ago (2012-07-16 18:01:00 UTC) #3

https://codereview.appspot.com/6409045/diff/1/tools/skdiff_main.cpp
File tools/skdiff_main.cpp (right):

https://codereview.appspot.com/6409045/diff/1/tools/skdiff_main.cpp#newcode1317
tools/skdiff_main.cpp:1317: return num_failing_results;
On 2012/07/16 17:56:46, rmistry wrote:
> [optional]
> return (num_failing_results > 255) ? 255 : num_failing_results;

That is better, thanks!

Expand All Messages | Collapse All Messages