Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(113)

Delta Between Two Patch Sets: worker/provisioner/provisioner.go

Issue 6408049: environs: turn environment configuration into a concrete type
Left Patch Set: Created 12 years, 8 months ago
Right Patch Set: environs: turn environment configuration into a concrete type Created 12 years, 8 months ago
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
Right: Side by side diff | Download
« no previous file with change/comment | « juju/conn_test.go ('k') | worker/provisioner/provisioner_test.go » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
(no file at all)
1 package provisioner 1 package provisioner
2 2
3 import ( 3 import (
4 "launchpad.net/juju-core/environs" 4 "launchpad.net/juju-core/environs"
5 "launchpad.net/juju-core/environs/config"
5 "launchpad.net/juju-core/log" 6 "launchpad.net/juju-core/log"
6 "launchpad.net/juju-core/state" 7 "launchpad.net/juju-core/state"
7 "launchpad.net/juju-core/state/watcher" 8 "launchpad.net/juju-core/state/watcher"
8 "launchpad.net/tomb" 9 "launchpad.net/tomb"
9 ) 10 )
10 11
11 type Provisioner struct { 12 type Provisioner struct {
12 st *state.State 13 st *state.State
13 info *state.Info 14 info *state.Info
14 environ environs.Environ 15 environ environs.Environ
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
49 for { 50 for {
50 select { 51 select {
51 case <-p.tomb.Dying(): 52 case <-p.tomb.Dying():
52 return 53 return
53 case config, ok := <-environWatcher.Changes(): 54 case config, ok := <-environWatcher.Changes():
54 if !ok { 55 if !ok {
55 p.tomb.Kill(watcher.MustErr(environWatcher)) 56 p.tomb.Kill(watcher.MustErr(environWatcher))
56 return 57 return
57 } 58 }
58 var err error 59 var err error
59 » » » p.environ, err = environs.NewEnviron(config.Map()) 60 » » » // TODO Change state so it hands off *config.Config.
61 » » » p.environ, err = environs.NewFromAttrs(config.Map())
60 if err != nil { 62 if err != nil {
61 log.Printf("provisioner loaded invalid environme nt configuration: %v", err) 63 log.Printf("provisioner loaded invalid environme nt configuration: %v", err)
62 continue 64 continue
63 } 65 }
64 log.Printf("provisioner loaded new environment configura tion") 66 log.Printf("provisioner loaded new environment configura tion")
65 if p.info, err = p.environ.StateInfo(); err != nil { 67 if p.info, err = p.environ.StateInfo(); err != nil {
66 p.tomb.Kill(err) 68 p.tomb.Kill(err)
67 return 69 return
68 } 70 }
69 break refreshState 71 break refreshState
(...skipping 12 matching lines...) Expand all
82 defer watcher.Stop(machinesWatcher, &p.tomb) 84 defer watcher.Stop(machinesWatcher, &p.tomb)
83 for { 85 for {
84 select { 86 select {
85 case <-p.tomb.Dying(): 87 case <-p.tomb.Dying():
86 return 88 return
87 case change, ok := <-environWatcher.Changes(): 89 case change, ok := <-environWatcher.Changes():
88 if !ok { 90 if !ok {
89 p.tomb.Kill(watcher.MustErr(environWatcher)) 91 p.tomb.Kill(watcher.MustErr(environWatcher))
90 return 92 return
91 } 93 }
92 » » » config, err := environs.NewConfig(change.Map()) 94 » » » // TODO Change state so it hands off *config.Config.
95 » » » config, err := config.New(change.Map())
93 if err != nil { 96 if err != nil {
94 log.Printf("provisioner loaded invalid environme nt configuration: %v", err) 97 log.Printf("provisioner loaded invalid environme nt configuration: %v", err)
95 continue 98 continue
96 } 99 }
97 p.environ.SetConfig(config) 100 p.environ.SetConfig(config)
98 log.Printf("provisioner loaded new environment configura tion") 101 log.Printf("provisioner loaded new environment configura tion")
99 case machines, ok := <-machinesWatcher.Changes(): 102 case machines, ok := <-machinesWatcher.Changes():
100 if !ok { 103 if !ok {
101 p.tomb.Kill(watcher.MustErr(machinesWatcher)) 104 p.tomb.Kill(watcher.MustErr(machinesWatcher))
102 return 105 return
(...skipping 176 matching lines...) Expand 10 before | Expand all | Expand 10 after
279 var insts []environs.Instance 282 var insts []environs.Instance
280 for _, m := range machines { 283 for _, m := range machines {
281 inst, err := p.instanceForMachine(m) 284 inst, err := p.instanceForMachine(m)
282 if err != nil { 285 if err != nil {
283 return nil, err 286 return nil, err
284 } 287 }
285 insts = append(insts, inst) 288 insts = append(insts, inst)
286 } 289 }
287 return insts, nil 290 return insts, nil
288 } 291 }
LEFTRIGHT

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b