Issue 6405080: Changed to a class based method in passing around the rendering method for render_pictures.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6405080: Changed to a class based method in passing around the rendering method for render_pictures. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by keyar

Modified:
11 years, 11 months ago

Reviewers:
junov, junov1, reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Changed to a class based method in passing around the rendering method for render_pictures. This is based on a comment for https://codereview.appspot.com/6427061/ Committed https://code.google.com/p/skia/source/detail?r=4786

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+213 lines, -117 lines)			Patch
M	gyp/tools.gyp	View	1	3 chunks	+17 lines, -2 lines	0 comments	Download
A	tools/PictureRenderer.h	View	1 2	1 chunk	+70 lines, -0 lines	0 comments	Download
A	tools/PictureRenderer.cpp	View	1	1 chunk	+101 lines, -0 lines	0 comments	Download
M	tools/render_pictures_main.cpp	View	1 2	7 chunks	+25 lines, -115 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

junov1

This is much cleaner. Thanks. https://codereview.appspot.com/6405080/diff/2001/tools/PictureRenderer.h File tools/PictureRenderer.h (right): https://codereview.appspot.com/6405080/diff/2001/tools/PictureRenderer.h#newcode61 tools/PictureRenderer.h:61: // We manuall delete ...

11 years, 11 months ago (2012-07-25 19:35:15 UTC) #2

junov1

11 years, 11 months ago (2012-07-25 19:56:01 UTC) #4

On 2012/07/25 19:53:33, keyar wrote:
> Made changes as requested by reviewers.

lgtm

Expand All Messages | Collapse All Messages