Issue 6405065: Add support for ARM without EDSP and ARMv6+

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6405065: Add support for ARM without EDSP and ARMv6+ (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by gw280

Modified:
12 years, 2 months ago

Reviewers:
digit, DerekS

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Add support for ARM without EDSP and ARMv6+ Original Mozilla bug: https://bugzilla.mozilla.org/show_bug.cgi?id=751814 Committed: https://code.google.com/p/skia/source/detail?r=4818

Patch Set 1 #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+58 lines, -7 lines)			Patch
M	include/core/SkMath.h	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	include/core/SkPostConfig.h	View	1 chunk	+45 lines, -0 lines	0 comments	Download
M	src/opts/SkBitmapProcState_opts_arm.cpp	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/opts/SkBlitRow_opts_arm.cpp	View	2 chunks	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

gw280

If you guys are willing to support ARMv6 it may be worth setting up a ...

12 years, 2 months ago (2012-07-20 15:51:58 UTC) #3

DerekS

digit, can you take a quick look at include/core/SkPostConfig.h and give your opinion on it ...

12 years, 2 months ago (2012-07-20 20:29:09 UTC) #4

DerekS

12 years, 2 months ago (2012-07-27 19:48:17 UTC) #6

On 2012/07/27 18:12:36, gwright wrote:
> Review ping?

lgtm. I've given it a spin on our supported devices and everything seemed to
work as intended.

Expand All Messages | Collapse All Messages