Issue 64044: Allow stylesheet link tags to bypass sanitization. General sanitization cleanup

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 64044: Allow stylesheet link tags to bypass sanitization. General sanitization cleanup

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years, 9 months ago by louiscryan

Modified:
16 years, 9 months ago

Reviewers:
shindig.remailer, etnu00

Base URL:
http://svn.apache.org/repos/asf/incubator/shindig/trunk/

Visibility:
Public.

Patch Set 1 #

Total comments: 1

Created: 16 years, 9 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+267 lines, -68 lines)			Patch
java/gadgets/src/main/java/org/apache/shindig/gadgets/render/RenderModule.java	View	2 chunks	+2 lines, -3 lines	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/render/SanitizingGadgetRewriter.java	View	8 chunks	+231 lines, -65 lines	1 comment	Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/render/SanitizingGadgetRewriterTest.java	View	2 chunks	+34 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

etnu00

16 years, 9 months ago (2009-05-20 00:10:16 UTC) #2

http://codereview.appspot.com/64044/diff/1/4
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/render/SanitizingGadgetRewriter.java
(right):

http://codereview.appspot.com/64044/diff/1/4#newcode200
Line 200: } //else if (tagResult == DomFilter.Allow.PASS)
I don't think you need this comment.

Expand All Messages | Collapse All Messages