Added picture recording benchmark options to bench.

Added picture recording benchmark options to bench.

-forceRecording benchmarks how long it takes C++ code to be recorded into a picture.

-forcePictureRecording benchmarks how long it takes a picture to be recorded into a picture.

Preliminary investigation shows that the second benchmarks can often be much faster than the first. Will rerun these benchmarks and upload the results somewhere when/if this code is committed.

Committed: https://code.google.com/p/skia/source/detail?r=4708

[nduca, 2012-07-18 01:11:18]

https://codereview.appspot.com/6404055/diff/1/bench/benchmain.cpp
File bench/benchmain.cpp (right):

https://codereview.appspot.com/6404055/diff/1/bench/benchmain.cpp#newcode358
bench/benchmain.cpp:358: SkDebugf("    -forceRecording 1|0 : "
seems like these different bools are mutually exclusive of one another. is
-mode=<normal,deferred|record|pictureRecord> a better option? Where mode is
usually normal?

Mind, I'm not familiar with skia conventions here

https://codereview.appspot.com/6404055/diff/1/bench/benchmain.cpp#newcode708
bench/benchmain.cpp:708: SkCanvas* tempCanvas =
pictureRecordFrom.beginRecording(dim.fX, dim.fY);
this flow kinda breaks my face. what does this do? Maybe a // to explain what
this trick does?

[keyar, 2012-07-18 18:21:41]

Made modifications as requested by reviewers.

[junov1, 2012-07-19 13:59:46]

https://codereview.appspot.com/6404055/diff/4001/bench/benchmain.cpp
File bench/benchmain.cpp (right):

https://codereview.appspot.com/6404055/diff/4001/bench/benchmain.cpp#newcode495
bench/benchmain.cpp:495: bool forceDeferred = false;
If this switch is now redundant, get rid of it.  Just make sure no test scripts
use it.  If they do, change the scripts.

https://codereview.appspot.com/6404055/diff/4001/bench/benchmain.cpp#newcode592
bench/benchmain.cpp:592: log_error("-forceRecording and -forcePictureRecording
are not"
I think you mean -mode record and -mode picturerecord

https://codereview.appspot.com/6404055/diff/4001/bench/benchmain.cpp#newcode789
bench/benchmain.cpp:789: // This stops the commands from acculmulating in the
picture
This comment is unclear.

[keyar, 2012-07-19 15:53:05]

Made fixes as wanted by reviewers.

[junov1, 2012-07-20 19:01:02]

On 2012/07/19 15:53:05, keyar wrote:
> Made fixes as wanted by reviewers.

lgtm