Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1905)

Issue 6403043: Embed Blit shader byte code in binary. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 9 months ago by apatrick1
Modified:
11 years, 9 months ago
Reviewers:
dgkoch
CC:
angleproject-review_googlegroups.com
Base URL:
http://angleproject.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Embed Blit shader byte code in binary. Ran a WebGL conformance test that exercises the blitter - copy-tex-image-2d-formats. Committed: https://code.google.com/p/angleproject/source/detail?r=1229

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+487 lines, -121 lines) Patch
M src/libGLESv2/Blit.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/libGLESv2/Blit.cpp View 4 chunks +29 lines, -119 lines 0 comments Download
A src/libGLESv2/shaders/Blit.ps View 1 chunk +39 lines, -0 lines 0 comments Download
A src/libGLESv2/shaders/Blit.vs View 1 chunk +43 lines, -0 lines 0 comments Download
A src/libGLESv2/shaders/componentmaskps.h View 1 chunk +81 lines, -0 lines 0 comments Download
A src/libGLESv2/shaders/flipyvs.h View 1 chunk +69 lines, -0 lines 0 comments Download
A src/libGLESv2/shaders/generate_shaders.bat View 1 chunk +14 lines, -0 lines 0 comments Download
A src/libGLESv2/shaders/luminanceps.h View 1 chunk +80 lines, -0 lines 0 comments Download
A src/libGLESv2/shaders/passthroughps.h View 1 chunk +63 lines, -0 lines 0 comments Download
A src/libGLESv2/shaders/standardvs.h View 1 chunk +69 lines, -0 lines 0 comments Download

Messages

Total messages: 2
apatrick1
What do you think about checking in the generated byte code headers? They could be ...
11 years, 9 months ago (2012-07-13 23:02:28 UTC) #1
dgkoch
11 years, 9 months ago (2012-07-18 23:05:31 UTC) #2
LGTM.

I'm fine without custom build rules since we haven't changed these at all since
they were originally written.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b