render_pictures can now do tiling based rendering.

render_pictures can now do tiling based rendering.

Committed: https://code.google.com/p/skia/source/detail?r=4707

[junov1, 2012-07-19 14:38:09]

https://codereview.appspot.com/6401057/diff/2001/tools/render_pictures_main.cpp
File tools/render_pictures_main.cpp (right):

https://codereview.appspot.com/6401057/diff/2001/tools/render_pictures_main.c...
tools/render_pictures_main.cpp:23: const int DEFAULT_TILE_HEIGHT = 256;
use kCamelCase in an anonymous enum

https://codereview.appspot.com/6401057/diff/2001/tools/render_pictures_main.c...
tools/render_pictures_main.cpp:50: int fTileWidth;
This seems to be related to a not yet implemented feature.  You should submit it
later when it becomes useful.

https://codereview.appspot.com/6401057/diff/2001/tools/render_pictures_main.c...
tools/render_pictures_main.cpp:126: static void clip_tile(SkPicture* picture,
const TileInfo& tile) {
Add comment to eplain what this does

https://codereview.appspot.com/6401057/diff/2001/tools/render_pictures_main.c...
tools/render_pictures_main.cpp:132: static void setup_single_tile(SkPicture*
picture, const Options& options,
I think this should be called add_tile or create_tile

https://codereview.appspot.com/6401057/diff/2001/tools/render_pictures_main.c...
tools/render_pictures_main.cpp:161:
tiles[tile_index].fCanvas->readPixels(bitmap, tile_y_start, tile_x_start);
This won't work the day we decide to use accelerated canvases  You should create
a canvas that has 'bitmap' as its backingstore and draw the tiles to it using
destinationCanvas->drawBitmap(tileCanvas->getDevice()->accessBitmap()).
This funct should receive a destination canvas rather than a destination bitmap
as an argument. That way it can remain GPU agnostic

[keyar, 2012-07-19 18:05:14]

Added reviewer requested changes.

[junov1, 2012-07-19 20:59:30]

https://codereview.appspot.com/6401057/diff/6003/tools/render_pictures_main.cpp
File tools/render_pictures_main.cpp (right):

https://codereview.appspot.com/6401057/diff/6003/tools/render_pictures_main.c...
tools/render_pictures_main.cpp:165: SkTArray<TileInfo> tiles;
Use SkTDArray for POD types.

[keyar, 2012-07-19 21:14:46]

A SkTDArray is being used for the tiles instead of an SkTArray.

[junov1, 2012-07-20 18:59:38]

lgtm