Issue 6400051: Cleaned up icons, added keyboard shortcuts to everything

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6400051: Cleaned up icons, added keyboard shortcuts to everything (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by chudy

Modified:
12 years, 4 months ago

Reviewers:
DerekS

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Cleaned up icons, added keyboard shortcuts to everything Keyboard Shortcuts and Menu reordering

Patch Set 2 : Fixed Derek's comment' #

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+710 lines, -1280 lines)			Patch
M	debugger/QT/SkCanvasWidget.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	debugger/QT/SkDebuggerGUI.h	View		3 chunks	+6 lines, -2 lines	0 comments	Download
M	debugger/QT/SkDebuggerGUI.cpp	View	1	9 chunks	+62 lines, -46 lines	0 comments	Download
M	debugger/QT/SkSettingsWidget.h	View		2 chunks	+0 lines, -4 lines	0 comments	Download
M	debugger/QT/SkSettingsWidget.cpp	View		3 chunks	+0 lines, -7 lines	0 comments	Download
M	debugger/QT/qrc_SkIcons.cpp	View		8 chunks	+641 lines, -1220 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

DerekS

lgtm with one suggestion https://codereview.appspot.com/6400051/diff/1/debugger/QT/SkDebuggerGUI.cpp File debugger/QT/SkDebuggerGUI.cpp (right): https://codereview.appspot.com/6400051/diff/1/debugger/QT/SkDebuggerGUI.cpp#newcode174 debugger/QT/SkDebuggerGUI.cpp:174: fListWidget.setCurrentRow(2); does setting to 0 ...

12 years, 4 months ago (2012-07-16 17:38:36 UTC) #2

chudy

12 years, 4 months ago (2012-07-16 18:34:05 UTC) #3

See comment and submitting... Thanks for the review

https://codereview.appspot.com/6400051/diff/1/debugger/QT/SkDebuggerGUI.cpp
File debugger/QT/SkDebuggerGUI.cpp (right):

https://codereview.appspot.com/6400051/diff/1/debugger/QT/SkDebuggerGUI.cpp#n...
debugger/QT/SkDebuggerGUI.cpp:174: fListWidget.setCurrentRow(2);
On 2012/07/16 17:38:38, DerekS wrote:
> does setting to 0 cause a problem? If not set it to 0 and remove the comment.

It did because it wouldn't clear anything but I fixed the bug itself in the
CanvasWidget file.

Expand All Messages | Collapse All Messages