Issue 6392054: skdiff: add --failonmismatches and --listfilename options, plus cleanup

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6392054: skdiff: add --failonmismatches and --listfilename options, plus cleanup (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 5 months ago by epoger

Modified:
12 years, 5 months ago

Reviewers:
rmistry

CC:
skia-review_googlegroups.com, TomH, bsalomon, EricB, keyar

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

skdiff: add --failonmismatches and --listfilename options, plus cleanup These changes are needed in order to switch the buildbots from using "gm -r" to "skdiff" to compare gm results, and should be generally good for humans too. Committed: https://code.google.com/p/skia/source/detail?r=4579

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 12 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+148 lines, -98 lines)			Patch
M	tools/skdiff_main.cpp	View	1	9 chunks	+114 lines, -70 lines	0 comments	Download
M	tools/tests/run.sh	View	1	1 chunk	+7 lines, -6 lines	0 comments	Download
M	tools/tests/skdiff/identical-bits-or-pixels/output-expected/command_line	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/tests/skdiff/identical-bits-or-pixels/output-expected/stdout	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	tools/tests/skdiff/identical-bits/output-expected/command_line	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/tests/skdiff/identical-bits/output-expected/stdout	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	tools/tests/skdiff/test1/output-expected/index.html	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tools/tests/skdiff/test1/output-expected/return_value	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/tests/skdiff/test1/output-expected/stdout	View	1	1 chunk	+8 lines, -7 lines	0 comments	Download
M	tools/tests/skdiff/test2/output-expected/command_line	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/tests/skdiff/test2/output-expected/stdout	View	1	1 chunk	+8 lines, -7 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rmistry

LGTM http://codereview.appspot.com/6392054/diff/1/tools/skdiff_main.cpp File tools/skdiff_main.cpp (right): http://codereview.appspot.com/6392054/diff/1/tools/skdiff_main.cpp#newcode63 tools/skdiff_main.cpp:63: return "contain the same pixel values"; [optional] "contain ...

12 years, 5 months ago (2012-07-12 18:00:14 UTC) #2

epoger

12 years, 5 months ago (2012-07-12 18:15:30 UTC) #3

http://codereview.appspot.com/6392054/diff/1/tools/skdiff_main.cpp
File tools/skdiff_main.cpp (right):

http://codereview.appspot.com/6392054/diff/1/tools/skdiff_main.cpp#newcode63
tools/skdiff_main.cpp:63: return "contain the same pixel values";
On 2012/07/12 18:00:15, rmistry wrote:
> [optional] "contain the same pixel values, but not the same bits"

Done.

Expand All Messages | Collapse All Messages