Issue 6392052: This patch reverts r1203, but in slightly different way. It seems there is a problem with the confi…

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6392052: This patch reverts r1203, but in slightly different way. It seems there is a problem with the confi… (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 9 months ago by Alok Priyadarshi

Modified:
13 years, 9 months ago

Reviewers:
dgkoch

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

This patch reverts r1203, but in slightly different way. It seems there is a problem with the config of memory bots. The usage of std::locale in ANGLE is fine. Committed: https://code.google.com/p/angleproject/source/detail?r=1205

Patch Set 1 #

Created: 13 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+90 lines, -59 lines)			Patch
M	src/build_angle.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/compiler/preprocessor/new/Token.cpp	View	2 chunks	+4 lines, -39 lines	0 comments	Download
A	src/compiler/preprocessor/new/numeric_lex.h	View	1 chunk	+61 lines, -0 lines	0 comments	Download
M	src/compiler/preprocessor/new/preprocessor.vcproj	View	5 chunks	+24 lines, -20 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

LGTM.  Don't forget to bump version.h

Expand All Messages | Collapse All Messages