Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1887)

Issue 6392050: code review 6392050: xts: add package. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 4 months ago by agl1
Modified:
7 years, 4 months ago
Reviewers:
CC:
golang-dev, r, dchest
Visibility:
Public.

Description

xts: add package. Package xts implements the XTS cipher mode as specified in IEEE P1619/D16.

Patch Set 1 #

Patch Set 2 : diff -r 942ebd6029e7 https://code.google.com/p/go.crypto #

Patch Set 3 : diff -r 942ebd6029e7 https://code.google.com/p/go.crypto #

Total comments: 10

Patch Set 4 : diff -r 942ebd6029e7 https://code.google.com/p/go.crypto #

Unified diffs Side-by-side diffs Delta from patch set Stats (+223 lines, -0 lines) Patch
A xts/xts.go View 1 2 3 1 chunk +138 lines, -0 lines 0 comments Download
A xts/xts_test.go View 1 1 chunk +85 lines, -0 lines 0 comments Download

Messages

Total messages: 4
agl1
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.crypto
7 years, 4 months ago (2012-07-11 19:32:52 UTC) #1
r
LGTM http://codereview.appspot.com/6392050/diff/5001/xts/xts.go File xts/xts.go (right): http://codereview.appspot.com/6392050/diff/5001/xts/xts.go#newcode7 xts/xts.go:7: // XTS mode is typically used for disk ...
7 years, 4 months ago (2012-07-11 21:20:21 UTC) #2
dchest
LGTM http://codereview.appspot.com/6392050/diff/5001/xts/xts.go File xts/xts.go (right): http://codereview.appspot.com/6392050/diff/5001/xts/xts.go#newcode58 xts/xts.go:58: // overlap. Sectors must be a multiple of ...
7 years, 4 months ago (2012-07-12 11:18:08 UTC) #3
agl1
7 years, 4 months ago (2012-07-12 15:24:30 UTC) #4
*** Submitted as
http://code.google.com/p/go/source/detail?r=d77655906ece&repo=crypto ***

xts: add package.

Package xts implements the XTS cipher mode as specified in IEEE
P1619/D16.

R=golang-dev, r, dchest
CC=golang-dev
http://codereview.appspot.com/6392050

http://codereview.appspot.com/6392050/diff/5001/xts/xts.go
File xts/xts.go (right):

http://codereview.appspot.com/6392050/diff/5001/xts/xts.go#newcode7
xts/xts.go:7: // XTS mode is typically used for disk encryption which presents a
number of
On 2012/07/11 21:20:21, r wrote:
> s/encryption/&,/

Done.

http://codereview.appspot.com/6392050/diff/5001/xts/xts.go#newcode57
xts/xts.go:57: // plaintext and ciphertext may be the same slice but should
otherwise not
On 2012/07/11 21:20:21, r wrote:
> s/p/P/
> not sure what 'otherwise' adds here. just delete it.

My thinking was that setting plaintext=ciphertext is a case of overlapping, but
otherwise overlapping isn't allowed.

But I guess that wasn't clear so I've removed otherwise.

http://codereview.appspot.com/6392050/diff/5001/xts/xts.go#newcode58
xts/xts.go:58: // overlap. Sectors must be a multiple of 16 bytes and less than
2*24 bytes.
On 2012/07/12 11:18:09, dchest wrote:
> 2²⁴

Thanks, done. (And I switched to using unicode superscript elsewhere in the
comments.)

http://codereview.appspot.com/6392050/diff/5001/xts/xts.go#newcode89
xts/xts.go:89: // plaintext and ciphertext may be the same slice but should
otherwise not
On 2012/07/11 21:20:21, r wrote:
> ditto and ditto.

Done.

http://codereview.appspot.com/6392050/diff/5001/xts/xts.go#newcode120
xts/xts.go:120: // mul2 multiplies tweak by 2 in GF(2**128) with an irreducable
polynomial of
On 2012/07/11 21:20:21, r wrote:
> irreducible.

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b