Builds for chrome memroy bots (windows only) do not link due to the usage of std::locale, the reaso…

Builds for chrome memroy bots (windows only) do not link due to the usage of std::locale, the reason for which is still unknown.
This patch avoids the usage of std::locale, while still enforcing "C" locale and checking for overflow.
Committed: https://code.google.com/p/angleproject/source/detail?r=1203

[Alok Priyadarshi, 2012-07-10 17:27:33]

Please review ASAP. Chrome memory bots are hosed.

[kbr1, 2012-07-10 17:42:12]

LGTM

[dgkoch, 2012-07-10 18:25:51]

Hrm.. any good reason not to use atof_dot (from compiler/utils.h). That's what
we use in the old preprocessor.  I can't recall if we'd looked into strtod
earlier and ruled that out or not...

[Alok Priyadarshi, 2012-07-10 18:29:48]

On 2012/07/10 18:25:51, dgkoch wrote:
> Hrm.. any good reason not to use atof_dot (from compiler/utils.h). That's what
> we use in the old preprocessor.  I can't recall if we'd looked into strtod
> earlier and ruled that out or not...

The one in util.cpp does not check for overflow.

[dgkoch, 2012-07-10 18:37:33]

On 2012/07/10 18:29:48, Alok Priyadarshi wrote:
> On 2012/07/10 18:25:51, dgkoch wrote:
> > Hrm.. any good reason not to use atof_dot (from compiler/utils.h). That's
what
> > we use in the old preprocessor.  I can't recall if we'd looked into strtod
> > earlier and ruled that out or not...
> 
> The one in util.cpp does not check for overflow.

Ok. How is that enforcing the C locale though?  The man page for strtod on the
mac says: "The decimal point character is defined in the program's locale
(category LC_NUMERIC)."

[Alok Priyadarshi, 2012-07-10 18:45:07]

On 2012/07/10 18:37:33, dgkoch wrote:
> On 2012/07/10 18:29:48, Alok Priyadarshi wrote:
> > On 2012/07/10 18:25:51, dgkoch wrote:
> > > Hrm.. any good reason not to use atof_dot (from compiler/utils.h). That's
> what
> > > we use in the old preprocessor.  I can't recall if we'd looked into strtod
> > > earlier and ruled that out or not...
> > 
> > The one in util.cpp does not check for overflow.
> 
> Ok. How is that enforcing the C locale though?  The man page for strtod on the
> mac says: "The decimal point character is defined in the program's locale
> (category LC_NUMERIC)."

You are right. I will take another stab at it.