Issue 6389043: Fixed memory leaks in SkDebuggerGUI

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6389043: Fixed memory leaks in SkDebuggerGUI (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by chudy

Modified:
11 years, 11 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Made everything in SkDebuggerGUI live on the stack

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixing merge conflicts #

Patch Set 3 : Messed up using -a command during commit, need to see what happens in patch set #

Patch Set 4 : Fixed moc modification #

Patch Set 5 : Once again fixing missing moc.sh #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+289 lines, -353 lines)			Patch
M	debugger/QT/SkDebuggerGUI.h	View	1	3 chunks	+37 lines, -46 lines	0 comments	Download
M	debugger/QT/SkDebuggerGUI.cpp	View	1	12 chunks	+226 lines, -281 lines	0 comments	Download
M	debugger/QT/moc_SkDebuggerGUI.cpp	View	1 2	4 chunks	+26 lines, -26 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

reed1

off hand, what is the value/reason to "make it live on the stack"? https://codereview.appspot.com/6389043/diff/1/debugger/QT/SkDebuggerGUI.h File ...

11 years, 11 months ago (2012-07-09 19:42:21 UTC) #2

chudy

11 years, 11 months ago (2012-07-09 20:12:16 UTC) #3

Following the same style Derek showed me in some other files. No need to
delete pointers in the destructor and maybe some minor performance
optimization.

I changed the state to a bool to make it self explanatory. Qt's
stateChanged signal it emits when a checkbox is clicked returns an int
because there are three seperate states that a checkbox can have. We are
only interested in checked and unchecked.

On Mon, Jul 9, 2012 at 3:42 PM, <reed@google.com> wrote:

> off hand, what is the value/reason to "make it live on the stack"?
>
>
> https://codereview.appspot.**com/6389043/diff/1/debugger/**
>
QT/SkDebuggerGUI.h<https://codereview.appspot.com/6389043/diff/1/debugger/QT/SkDebuggerGUI.h>
> File debugger/QT/SkDebuggerGUI.h (right):
>
> https://codereview.appspot.**com/6389043/diff/1/debugger/**
>
QT/SkDebuggerGUI.h#newcode135<https://codereview.appspot.com/6389043/diff/1/debugger/QT/SkDebuggerGUI.h#newcode135>
> debugger/QT/SkDebuggerGUI.h:**135: or simple focus.
> What is "state"? an enum? flags? bool?
>
>
https://codereview.appspot.**com/6389043/<https://codereview.appspot.com/6389...
>

-- 
*Karol Chudy*
Phone: (203) 898-4233
chudy@google.com

Expand All Messages | Collapse All Messages