Issue 63760043: Issue 1575:Refine NUMSCALE question UI at InstructorFeedbackEdit

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 63760043: Issue 1575:Refine NUMSCALE question UI at InstructorFeedbackEdit

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by Xia Lu

Modified:
10 years, 8 months ago

Reviewers:
arnold.koroa

Visibility:
Public.

More Reviews

Description

Issue 1575:Refine NUMSCALE question UI at InstructorFeedbackEdit

Patch Set 1 #

Total comments: 4

Patch Set 2 : Issue 1575:Refine NUMSCALE question UI at InstructorFeedbackEdit #

Patch Set 3 : Issue 1575:Refine NUMSCALE question UI at InstructorFeedbackEdit #

Patch Set 4 : Issue 1575:Refine NUMSCALE question UI at InstructorFeedbackEdit #

Patch Set 5 : Issue 1575:Refine NUMSCALE question UI at InstructorFeedbackEdit #

Created: 10 years, 8 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+313 lines, -374 lines)			Patch
M	.project	View	1 2 3	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	src/main/java/teammates/common/util/Const.java	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	src/main/resources/feedbackQuestionNumScaleEditFormTemplate.html	View		1 chunk	+11 lines, -11 lines	0 comments	Download
M	src/main/webapp/js/instructorFeedbackEdit.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/main/webapp/jsp/instructorFeedbackEdit.jsp	View		1 chunk	+14 lines, -14 lines	0 comments	Download
M	src/test/java/teammates/test/cases/ui/browsertests/InstructorFeedbackEditPageUiTest.java	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	src/test/resources/pages/instructorFeedbackAddSuccess.html	View		1 chunk	+20 lines, -25 lines	0 comments	Download
M	src/test/resources/pages/instructorFeedbackEditEmpty.html	View		1 chunk	+19 lines, -24 lines	0 comments	Download
M	src/test/resources/pages/instructorFeedbackEditPublished.html	View		1 chunk	+20 lines, -25 lines	0 comments	Download
M	src/test/resources/pages/instructorFeedbackEditSuccess.html	View		1 chunk	+20 lines, -25 lines	0 comments	Download
M	src/test/resources/pages/instructorFeedbackMcqQuestionAddSuccess.html	View		1 chunk	+20 lines, -25 lines	0 comments	Download
M	src/test/resources/pages/instructorFeedbackMcqQuestionEditSuccess.html	View		1 chunk	+20 lines, -25 lines	0 comments	Download
M	src/test/resources/pages/instructorFeedbackMsqQuestionAddSuccess.html	View		1 chunk	+21 lines, -26 lines	0 comments	Download
M	src/test/resources/pages/instructorFeedbackMsqQuestionEditSuccess.html	View		2 chunks	+21 lines, -26 lines	0 comments	Download
M	src/test/resources/pages/instructorFeedbackNumScaleQuestionAddSuccess.html	View		2 chunks	+40 lines, -47 lines	0 comments	Download
M	src/test/resources/pages/instructorFeedbackNumScaleQuestionEditSuccess.html	View		2 chunks	+40 lines, -47 lines	0 comments	Download
M	src/test/resources/pages/instructorFeedbackQuestionAddSuccess.html	View		1 chunk	+20 lines, -25 lines	0 comments	Download
M	src/test/resources/pages/instructorFeedbackQuestionEditSuccess.html	View		1 chunk	+20 lines, -25 lines	0 comments	Download
M	upload.py	View		0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

arnold.koroa

10 years, 8 months ago (2014-02-14 06:30:50 UTC) #1

https://codereview.appspot.com/63760043/diff/1/.project
File .project (right):

https://codereview.appspot.com/63760043/diff/1/.project#newcode37
.project:37: </buildCommand>
The added/removed block looks the same. Just in case just revert the change?
Will that affect your eclipse somehow?

https://codereview.appspot.com/63760043/diff/1/.settings/com.google.appengine...
File .settings/com.google.appengine.eclipse.core.prefs (right):

https://codereview.appspot.com/63760043/diff/1/.settings/com.google.appengine...
.settings/com.google.appengine.eclipse.core.prefs:6: gaeLaunchAppInBrowser=true
let's not modify global settings as it will affect everywone (may I know what
setting this is though?)

https://codereview.appspot.com/63760043/diff/1/hgrc
File hgrc (right):

https://codereview.appspot.com/63760043/diff/1/hgrc#newcode12
hgrc:12: git=1
don't add this file to the repo as it is user-specific

https://codereview.appspot.com/63760043/diff/1/src/test/java/testNG/NewTest.java
File src/test/java/testNG/NewTest.java (right):

https://codereview.appspot.com/63760043/diff/1/src/test/java/testNG/NewTest.j...
src/test/java/testNG/NewTest.java:8: }
Is this used? If not remove?

Expand All Messages | Collapse All Messages