Issue 6357050: Implement binary streams.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6357050: Implement binary streams. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by apatrick1

Modified:
11 years, 10 months ago

Reviewers:
dgkoch

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Implement binary streams. Committed: https://code.google.com/p/angleproject/source/detail?r=1200

Patch Set 2 : Implement binary streams. #

Patch Set 3 : #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+172 lines, -1 line)			Patch
M	src/build_angle.gyp	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/common/version.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
A	src/libGLESv2/BinaryStream.h	View	1 2	1 chunk	+166 lines, -0 lines	0 comments	Download
M	src/libGLESv2/libGLESv2.vcproj	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

apatrick1

This is to make OES_get_program_binary actually binary. https://codereview.appspot.com/6357050/diff/2001/src/libGLESv2/Texture.cpp File src/libGLESv2/Texture.cpp (right): https://codereview.appspot.com/6357050/diff/2001/src/libGLESv2/Texture.cpp#newcode322 src/libGLESv2/Texture.cpp:322: std::string foo("foo"); ...

11 years, 10 months ago (2012-06-28 23:17:34 UTC) #1

dgkoch

LGTM - presumably this needs to be hooked up for the program binary loading/saving? https://codereview.appspot.com/6357050/diff/2001/src/libGLESv2/BinaryStream.h ...

11 years, 10 months ago (2012-07-05 03:44:48 UTC) #2

Implement binary streams.

Expand All Messages | Collapse All Messages