Issue 6356094: Seperated Space for displaying breakpoint and deletion icons

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6356094: Seperated Space for displaying breakpoint and deletion icons (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by chudy

Modified:
11 years, 11 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Seperated Space for displaying breakpoint and deletion icons

Patch Set 2 : Addressing Comment #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -50 lines)			Patch
	M	debugger/QT/SkDebuggerGUI.cpp	View		2 chunks	+6 lines, -31 lines	0 comments	Download
	M	debugger/QT/SkListWidget.cpp	View	1	4 chunks	+41 lines, -19 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

reed1

https://codereview.appspot.com/6356094/diff/1/debugger/QT/SkListWidget.cpp File debugger/QT/SkListWidget.cpp (right): https://codereview.appspot.com/6356094/diff/1/debugger/QT/SkListWidget.cpp#newcode70 debugger/QT/SkListWidget.cpp:70: r = option.rect.adjusted(19, 10, -10, -10); can we add ...

11 years, 11 months ago (2012-07-12 12:27:35 UTC) #2

chudy

11 years, 11 months ago (2012-07-12 14:15:39 UTC) #3

Added comments through-out, renamed variables, in general cleaned up file.

Submitting...

https://codereview.appspot.com/6356094/diff/1/debugger/QT/SkListWidget.cpp
File debugger/QT/SkListWidget.cpp (right):

https://codereview.appspot.com/6356094/diff/1/debugger/QT/SkListWidget.cpp#ne...
debugger/QT/SkListWidget.cpp:70: r = option.rect.adjusted(19, 10, -10, -10);
On 2012/07/12 12:27:35, reed1 wrote:
> can we add a comment above each of these adjusted rects, so the reader knows
> what each is for, and how the values were chosen?

Done.

Expand All Messages | Collapse All Messages