Issue 6356045: Introduced preprocessing token types. This fixes a bug where invalid tokens inside excluded conditi…

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6356045: Introduced preprocessing token types. This fixes a bug where invalid tokens inside excluded conditi… (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by Alok Priyadarshi

Modified:
11 years, 10 months ago

Reviewers:

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Introduced preprocessing token types. This fixes a bug where invalid tokens inside excluded conditional block may report diagnostics. Now we let the invalid tokens to bubble through the preprocessor so that they have chance to be skipped. Committed: https://code.google.com/p/angleproject/source/detail?r=1169

Patch Set 1 #

Patch Set 2 : #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+55 lines, -36 lines)			Patch
M	src/compiler/preprocessor/new/DirectiveParser.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/compiler/preprocessor/new/Preprocessor.cpp	View	3 chunks	+33 lines, -5 lines	0 comments	Download
M	src/compiler/preprocessor/new/Token.h	View	1 chunk	+8 lines, -1 line	0 comments	Download
M	src/compiler/preprocessor/new/Tokenizer.cpp	View	3 chunks	+6 lines, -14 lines	0 comments	Download
M	src/compiler/preprocessor/new/Tokenizer.l	View	3 chunks	+6 lines, -14 lines	0 comments	Download