Issue 6355090: environs/ec2: enable local ec2 provisioner tests

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6355090: environs/ec2: enable local ec2 provisioner tests (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 8 months ago by dave

Modified:
12 years, 8 months ago

Reviewers:
mp+114323, niemeyer

Visibility:
Public.

Description

environs/ec2: enable local ec2 provisioner tests This proposal enables the provisioner bootstrap tests in ec2 local mode. https://code.launchpad.net/~dave-cheney/juju-core/go-environs-ec2-cloudinit-local-tests/+merge/114323 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : environs/ec2: enable local ec2 provisioner tests #

Created: 12 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -7 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/ec2/local_test.go	View	1	4 chunks	+13 lines, -2 lines	0 comments	Download
M	environs/ec2/suite_test.go	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	environs/jujutest/livetests.go	View	1	4 chunks	+30 lines, -1 line	0 comments	Download
M	environs/jujutest/test.go	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

niemeyer

12 years, 8 months ago (2012-07-11 23:07:01 UTC) #3

Thanks for bringing this back for discussion, Dave.

So, with this clearly isolated, I ask: what is actually being tested with this
patch in, that is not tested without it?

This change:

- Has a provisioner that is not created by the tested code

- Has a state that is not created by the tested code

- Fakes the location where the information of how to connect to the state is
obtained

- Special cases further the generic tests for the local provider

- Creates a dependency from livetests onto EC2 that is unnacceptable; livetests
are generic, and should continue being generic.

- As far as I can see, does not exercise any new paths


For all of those reasons, I'm -1 on it.

Expand All Messages | Collapse All Messages