WebGL spec specifies maximum length of all types of tokens - not just identifier tokens. And it als…

WebGL spec specifies maximum length of all types of tokens - not just identifier tokens. And it also means preprocessing-tokens, not compiler tokens.
Note that this implies that non-compliant tokens even inside excluded #if blocks will trigger error.

TODO: This behavior should be implemented as a preprocessor option, so that a GLES2 compiler can choose to disable it.
Committed: https://code.google.com/p/angleproject/source/detail?r=1193

[kbr1, 2012-07-03 22:19:27]

LGTM with one naming comment.

http://codereview.appspot.com/6355066/diff/1/src/compiler/preprocessor/new/Di...
File src/compiler/preprocessor/new/Diagnostics.cpp (right):

http://codereview.appspot.com/6355066/diff/1/src/compiler/preprocessor/new/Di...
src/compiler/preprocessor/new/Diagnostics.cpp:56: return "token buffer
overflow";
Could we consider naming this something like "TOKEN_TOO_LONG"? "Buffer overflow"
sounds like a security bug.

[Alok Priyadarshi, 2012-07-09 15:51:19]

http://codereview.appspot.com/6355066/diff/1/src/compiler/preprocessor/new/Di...
File src/compiler/preprocessor/new/Diagnostics.cpp (right):

http://codereview.appspot.com/6355066/diff/1/src/compiler/preprocessor/new/Di...
src/compiler/preprocessor/new/Diagnostics.cpp:56: return "token buffer
overflow";
On 2012/07/03 22:19:27, kbr1 wrote:
> Could we consider naming this something like "TOKEN_TOO_LONG"? "Buffer
overflow"
> sounds like a security bug.

Good suggestion. Should I rename INTEGER_OVERFLOW and FLOAT_OVERFLOW to
INTEGER_TOO_LARGE and FLOAT_TOO_LARGE as well?