Issue 6355058: Re-enables test.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6355058: Re-enables test. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by hsumita1

Modified:
11 years, 10 months ago

Reviewers:
shawn.p.huang, Peng Huang, penghuang

Base URL:
git@github.com:pyzy/pyzy.git@master

Visibility:
Public.

More Reviews

Description

Re-enables test. BUG=None TEST=Build and run a test.

Patch Set 2 : Refines setUp and tearDown. #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1179 lines, -0 lines)			Patch
M	configure.ac	View		3 chunks	+11 lines, -0 lines	0 comments	Download
M	src/Makefile.am	View		1 chunk	+7 lines, -0 lines	0 comments	Download
A	src/tests/.gitignore	View		1 chunk	+2 lines, -0 lines	0 comments	Download
A	src/tests/Makefile.am	View		1 chunk	+57 lines, -0 lines	0 comments	Download
A	src/tests/basic.cc	View	1	1 chunk	+1102 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Peng

On 2012/07/02 11:51:02, hsumita1 wrote: lgtm with a comment

11 years, 10 months ago (2012-07-02 12:59:49 UTC) #2

Peng

https://codereview.appspot.com/6355058/diff/1/src/Makefile.am File src/Makefile.am (right): https://codereview.appspot.com/6355058/diff/1/src/Makefile.am#newcode38 src/Makefile.am:38: . \ Is it necessary put '.' here?

11 years, 10 months ago (2012-07-02 12:59:55 UTC) #3

hsumita1

11 years, 10 months ago (2012-07-03 02:37:35 UTC) #4

I refines some codes.
Could you review it again?

Expand All Messages | Collapse All Messages