Issue 6354097: Added a benchmark for measuring picture unflattening time.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6354097: Added a benchmark for measuring picture unflattening time. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by keyar

Modified:
12 years, 4 months ago

Reviewers:
junov1, reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Added a benchmark for measuring picture unflattening time. Committed http://code.google.com/p/skia/source/detail?r=4582

Patch Set 2 : Ignored first run of unflatten benchmark. #

Patch Set 3 : Minor grammer fix. #

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -0 lines)			Patch
	M	tools/bench_pictures_main.cpp	View	1 2	3 chunks	+28 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

junov1

minor comments. Otherwise lgtm https://codereview.appspot.com/6354097/diff/1/tools/bench_pictures_main.cpp File tools/bench_pictures_main.cpp (right): https://codereview.appspot.com/6354097/diff/1/tools/bench_pictures_main.cpp#newcode64 tools/bench_pictures_main.cpp:64: "Set to do an picture ...

12 years, 4 months ago (2012-07-12 18:57:28 UTC) #2

keyar

12 years, 4 months ago (2012-07-12 19:17:06 UTC) #3

On 2012/07/12 18:57:28, junov1 wrote:
> minor comments.
> Otherwise lgtm
> 
> https://codereview.appspot.com/6354097/diff/1/tools/bench_pictures_main.cpp
> File tools/bench_pictures_main.cpp (right):
> 
>
https://codereview.appspot.com/6354097/diff/1/tools/bench_pictures_main.cpp#n...
> tools/bench_pictures_main.cpp:64: "Set to do an picture unflattening
benchmark.
> Default is not to do this.\n");
> a picture
> 
>
https://codereview.appspot.com/6354097/diff/1/tools/bench_pictures_main.cpp#n...
> tools/bench_pictures_main.cpp:191: SkCanvas* recorder =
> replayer.beginRecording(commands->width(), commands->height());
> 80 col
> 
>
https://codereview.appspot.com/6354097/diff/1/tools/bench_pictures_main.cpp#n...
> tools/bench_pictures_main.cpp:193: recorder->drawPicture(*commands);
> Sux that SkPicture has no copy constructor.  :-)

There is a copy constructor, however it unflattens the picture.

Expand All Messages | Collapse All Messages