bench_pictures can now take percentages for tiling width and height.

bench_pictures can now takes percentages for tiling width and height.

Committed http://code.google.com/p/skia/source/detail?r=4516

[junov1, 2012-07-06 20:33:02]

https://codereview.appspot.com/6354074/diff/1/tools/bench_pictures_main.cpp
File tools/bench_pictures_main.cpp (right):

https://codereview.appspot.com/6354074/diff/1/tools/bench_pictures_main.cpp#n...
tools/bench_pictures_main.cpp:163: options->fTileWidth =
ceil(options->fTileWidthPercentage * picture.width() / 100);
use sk_float_ceil2int, and remove include math.h above.

[keyar, 2012-07-06 22:21:18]

Changed to using sk_float_ceil2int instead of ceil in math.h.

[reed1, 2012-07-09 13:20:04]

https://codereview.appspot.com/6354074/diff/4001/tools/bench_pictures_main.cpp
File tools/bench_pictures_main.cpp (right):

https://codereview.appspot.com/6354074/diff/4001/tools/bench_pictures_main.cp...
tools/bench_pictures_main.cpp:30: int fTileHeight;
Do we really need bools as well, since you've already guaranteed that the
Percentage field will be 0 if we not using percent, and > 0 if we are? Why not
just perform if (percent > 0) to know if we should use it?

https://codereview.appspot.com/6354074/diff/4001/tools/bench_pictures_main.cp...
tools/bench_pictures_main.cpp:32: bool fUseTileHeightPercentage;
You call atof() but store the result in double? I think floats are sufficient
here.

[keyar, 2012-07-09 18:13:19]

Changed to checking that the percentage variable is > 0 as opposed to having a
separate Boolean.

https://codereview.appspot.com/6354074/diff/4001/tools/bench_pictures_main.cpp
File tools/bench_pictures_main.cpp (right):

https://codereview.appspot.com/6354074/diff/4001/tools/bench_pictures_main.cp...
tools/bench_pictures_main.cpp:32: bool fUseTileHeightPercentage;
On 2012/07/09 13:20:04, reed1 wrote:
> You call atof() but store the result in double? I think floats are sufficient
> here.
atof returns a double according to cplusplus.com.

[reed1, 2012-07-09 18:25:30]

On 2012/07/09 18:13:19, keyar wrote:
> Changed to checking that the percentage variable is > 0 as opposed to having a
> separate Boolean.
> 
> https://codereview.appspot.com/6354074/diff/4001/tools/bench_pictures_main.cpp
> File tools/bench_pictures_main.cpp (right):
> 
>
https://codereview.appspot.com/6354074/diff/4001/tools/bench_pictures_main.cp...
> tools/bench_pictures_main.cpp:32: bool fUseTileHeightPercentage;
> On 2012/07/09 13:20:04, reed1 wrote:
> > You call atof() but store the result in double? I think floats are
sufficient
> > here.
> atof returns a double according to http://cplusplus.com.

Ah, right you are.

[reed1, 2012-07-09 18:25:38]

lgtm

[keyar, 2012-07-09 20:37:42]

Had to do some merge work. Please take another look over.

[junov1, 2012-07-10 18:06:45]

On 2012/07/09 20:37:42, keyar wrote:
> Had to do some merge work. Please take another look over.

lgtm