Issue 6353097: Recognize QNX as POSIX

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6353097: Recognize QNX as POSIX (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 9 months ago by mvujovic

Modified:
13 years, 9 months ago

Reviewers:
kbr1

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Recognize QNX as POSIX. It looks like this change in WebKit's copy of ANGLE, but it wasn't ported back to ANGLE. Joshua Netterfield from RIM requested this while I was updating ANGLE in WebKit: """ Comment #57 From Joshua Netterfield 2012-07-12 09:19:34 PST > Source/ThirdParty/ANGLE/src/compiler/osinclude.h:-20 > - defined(__GLIBC__) || defined(__GNU__) || defined(__QNX__) QNX systems are POSIX. I'll submit a bug to ANGLE, but in the meantime could you continue to recognize QNX as POSIX? """ (https://bugs.webkit.org/show_bug.cgi?id=89039)

Patch Set 1 #

Created: 13 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	src/compiler/osinclude.h	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

mvujovic

Can someone review this? It's a small change :) Thanks! Max

13 years, 9 months ago (2012-07-12 23:32:07 UTC) #1

mvujovic

13 years, 9 months ago (2012-07-13 17:34:44 UTC) #3

On 2012/07/13 00:19:20, kbr1 wrote:
> LGTM

Thanks, Ken. Committed in r1223.

Expand All Messages | Collapse All Messages