Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2123)

Issue 6353053: Add Google C++ Eclipse style config.

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 4 months ago by Alexei Svitkine
Modified:
12 years, 4 months ago
Reviewers:
Mark Mentovai, erg
CC:
Mark Mentovai
Base URL:
http://google-styleguide.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Add Google C++ Eclipse style config.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -0 lines) Patch
A eclipse-cpp-google-style.xml View 1 chunk +167 lines, -0 lines 0 comments Download

Messages

Total messages: 5
Alexei Svitkine
This is exported from the google3 eclipse c++ style. I've gotten this approved internally as ...
12 years, 4 months ago (2012-06-29 17:02:12 UTC) #1
erg
On 2012/06/29 17:02:12, Alexei Svitkine wrote: > This is exported from the google3 eclipse c++ ...
12 years, 4 months ago (2012-06-29 17:13:43 UTC) #2
Alexei Svitkine
Thanks! I'm not a committer to google-styleguide - can you land it for me?
12 years, 4 months ago (2012-06-29 17:18:38 UTC) #3
Mark Mentovai
LGTM. Committed r84. http://google-styleguide.googlecode.com/svn/trunk/eclipse-cpp-google-style.xml
12 years, 4 months ago (2012-06-29 19:26:36 UTC) #4
Alexei Svitkine
12 years, 4 months ago (2012-06-29 19:34:11 UTC) #5
Thanks!

On Fri, Jun 29, 2012 at 3:26 PM, <mark@chromium.org> wrote:

> LGTM. Committed r84.
>
> http://google-styleguide.**googlecode.com/svn/trunk/**
>
eclipse-cpp-google-style.xml<http://google-styleguide.googlecode.com/svn/trunk/eclipse-cpp-google-style.xml>
>
>
https://codereview.appspot.**com/6353053/<https://codereview.appspot.com/6353...
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b