Issue 6353053: Add Google C++ Eclipse style config.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6353053: Add Google C++ Eclipse style config.

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by Alexei Svitkine

Modified:
12 years, 6 months ago

Reviewers:
Mark Mentovai, erg

CC:
Mark Mentovai

Base URL:
http://google-styleguide.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Add Google C++ Eclipse style config.

Patch Set 1 #

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+167 lines, -0 lines)			Patch
	A	eclipse-cpp-google-style.xml	View		1 chunk	+167 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Alexei Svitkine

This is exported from the google3 eclipse c++ style. I've gotten this approved internally as ...

12 years, 6 months ago (2012-06-29 17:02:12 UTC) #1

erg

On 2012/06/29 17:02:12, Alexei Svitkine wrote: > This is exported from the google3 eclipse c++ ...

12 years, 6 months ago (2012-06-29 17:13:43 UTC) #2

Alexei Svitkine

Thanks! I'm not a committer to google-styleguide - can you land it for me?

12 years, 6 months ago (2012-06-29 17:18:38 UTC) #3

Mark Mentovai

LGTM. Committed r84. http://google-styleguide.googlecode.com/svn/trunk/eclipse-cpp-google-style.xml

12 years, 6 months ago (2012-06-29 19:26:36 UTC) #4

Alexei Svitkine

12 years, 6 months ago (2012-06-29 19:34:11 UTC) #5

Thanks!

On Fri, Jun 29, 2012 at 3:26 PM, <mark@chromium.org> wrote:

> LGTM. Committed r84.
>
> http://google-styleguide.**googlecode.com/svn/trunk/**
>
eclipse-cpp-google-style.xml<http://google-styleguide.googlecode.com/svn/trunk/eclipse-cpp-google-style.xml>
>
>
https://codereview.appspot.**com/6353053/<https://codereview.appspot.com/6353...
>

Expand All Messages | Collapse All Messages