code review 63530043: gosshnew/ssh: Move test data to testdata directory.

gosshnew/ssh: Move test data to testdata directory.

[jpsugar, 2014-02-13 23:09:56]

Hello hanwen@google.com, agl@golang.org (cc: agl@golang.org, dave@cheney.net,
golang-codereviews@googlegroups.com, hanwen@google.com, jpsugar@google.com),

I'd like you to review this change to
https://code.google.com/p/gosshnew

[jpsugar, 2014-02-13 23:11:41]

I'm not a fan of the duplication of testdata_test.go. I'm considering making
testdata a package, and having it export the objects directly. Thoughts?

[hanwen-google, 2014-02-14 09:02:43]

https://codereview.appspot.com/63530043/diff/20001/ssh/test/test_unix_test.go
File ssh/test/test_unix_test.go (right):

https://codereview.appspot.com/63530043/diff/20001/ssh/test/test_unix_test.go...
ssh/test/test_unix_test.go:27: var configTmpl =
template.Must(template.ParseFiles("../testdata/sshd_config"))
I think this is over the top - the sshd config is only useful for this
directory.

https://codereview.appspot.com/63530043/diff/20001/ssh/testkeys_test.go
File ssh/testkeys_test.go (right):

https://codereview.appspot.com/63530043/diff/20001/ssh/testkeys_test.go#newco...
ssh/testkeys_test.go:32: rawRSAKey, rsaKey     = loadPrivateKey("id_rsa")
Let's just export the symbol? Since it's inside the testdata package there is no
downside.

[jpsugar, 2014-02-15 05:28:30]

https://codereview.appspot.com/63530043/diff/20001/ssh/testkeys_test.go
File ssh/testkeys_test.go (right):

https://codereview.appspot.com/63530043/diff/20001/ssh/testkeys_test.go#newco...
ssh/testkeys_test.go:32: rawRSAKey, rsaKey     = loadPrivateKey("id_rsa")
On 2014/02/14 09:02:44, hanwen-google wrote:
> Let's just export the symbol? Since it's inside the testdata package there is
no
> downside.

This is in the ssh package.

[hanwen-google, 2014-02-18 09:38:59]

I'm not a fan of using files: they introduce extra boilerplate, because reading
them back from disk can fail, and need extra work to make work if the test is
not run from the source dir. Also, sshd may enforce permissions for private keys
so you have to read and write them to a different file anyway.

Why not declare a bunch of exported constants in a testdata package,

  var RSAKey = []byte("--RSA PRIVATE KEY--\n....")

then you can access them without having to go through the operating system, and
we can still share all the binary data between different directories.

https://codereview.appspot.com/63530043/diff/20001/ssh/testdata/id_rsa
File ssh/testdata/id_rsa (right):

https://codereview.appspot.com/63530043/diff/20001/ssh/testdata/id_rsa#newcode1
ssh/testdata/id_rsa:1: -----BEGIN RSA PRIVATE KEY-----
if you use hg mv, the diffs will be shown correctly.

[jpsugar, 2014-02-18 16:29:03]

*** Abandoned ***