For bench_pictures, tiles that extend beyond the picture are now clipped.

Tiles that extend beyond the picture are now clipped.

[junov1, 2012-07-06 20:24:27]

Looks OK to me.

https://codereview.appspot.com/6352078/diff/1/tools/bench_pictures_main.cpp
File tools/bench_pictures_main.cpp (right):

https://codereview.appspot.com/6352078/diff/1/tools/bench_pictures_main.cpp#n...
tools/bench_pictures_main.cpp:89: tile.fCanvas->clipRect(clip);
I suppose the translate at line 101 affects the clip rect?

[keyar, 2012-07-06 21:10:03]

On 2012/07/06 20:24:27, junov1 wrote:
> Looks OK to me.
> 
> https://codereview.appspot.com/6352078/diff/1/tools/bench_pictures_main.cpp
> File tools/bench_pictures_main.cpp (right):
> 
>
https://codereview.appspot.com/6352078/diff/1/tools/bench_pictures_main.cpp#n...
> tools/bench_pictures_main.cpp:89: tile.fCanvas->clipRect(clip);
> I suppose the translate at line 101 affects the clip rect?

It looks to be that way. If I translate the clip rect -tile_x_start
-tile_y_start and write out an image, then the image ends up being wrong.

[reed1, 2012-07-09 13:15:35]

https://codereview.appspot.com/6352078/diff/1/tools/bench_pictures_main.cpp
File tools/bench_pictures_main.cpp (right):

https://codereview.appspot.com/6352078/diff/1/tools/bench_pictures_main.cpp#n...
tools/bench_pictures_main.cpp:100: tile.fCanvas = new SkCanvas(*(tile.fBitmap));
I think we can/should always clip right after we create the canvas, before we
translate. Is there a good reason to use should_clip?

[keyar, 2012-07-09 18:56:43]

https://codereview.appspot.com/6352078/diff/1/tools/bench_pictures_main.cpp
File tools/bench_pictures_main.cpp (right):

https://codereview.appspot.com/6352078/diff/1/tools/bench_pictures_main.cpp#n...
tools/bench_pictures_main.cpp:100: tile.fCanvas = new SkCanvas(*(tile.fBitmap));
On 2012/07/09 13:15:35, reed1 wrote:
> I think we can/should always clip right after we create the canvas, before we
> translate. Is there a good reason to use should_clip?

I can clip all the pictures instead of using should_clip to make the code
simpler.

We translate first so that we don't have to worry about how the clip rect needs
to be translated.

[reed1, 2012-07-09 19:34:34]

lgtm w/ suggestion to simplify parameters to clip_tile

https://codereview.appspot.com/6352078/diff/6001/tools/bench_pictures_main.cpp
File tools/bench_pictures_main.cpp (left):

https://codereview.appspot.com/6352078/diff/6001/tools/bench_pictures_main.cp...
tools/bench_pictures_main.cpp:82: SkTArray<TileInfo>* tiles,
do we need options now?