Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(842)

Issue 6352066: Another fix for drawing bitmaps through an SkGPipe that share pixelrefs. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years ago by Leon
Modified:
12 years ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlecode.com/svn/trunk
Visibility:
Public.

Description

Another fix for drawing bitmaps through an SkGPipe that share pixelrefs. In addition to checking the offset, also check to ensure that the width and height match, so that a subset which includes the upper left corner will be handled properly as well.

Patch Set 1 #

Patch Set 2 : Add a some test cases. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -9 lines) Patch
M gm/extractbitmap.cpp View 1 1 chunk +23 lines, -3 lines 0 comments Download
M src/pipe/SkGPipeWrite.cpp View 1 chunk +9 lines, -6 lines 0 comments Download

Messages

Total messages: 2
Leon
12 years ago (2012-07-02 18:53:44 UTC) #1
reed1
12 years ago (2012-07-02 21:02:04 UTC) #2
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b