Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(384)

Issue 6352059: Lowered the severity of EOF_IN_DIRECTIVE from an ERROR to WARNING. There are just too many shaders … (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 9 months ago by Alok Priyadarshi
Modified:
13 years, 9 months ago
Reviewers:
kbr1
CC:
angleproject-review_googlegroups.com
Base URL:
http://angleproject.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Lowered the severity of EOF_IN_DIRECTIVE from an ERROR to WARNING. There are just too many shaders on internet (including webgl conformance test) that do not have a newline at the end of directives, especially #endif. Committed: https://code.google.com/p/angleproject/source/detail?r=1185

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/compiler/preprocessor/new/Diagnostics.h View 2 chunks +1 line, -1 line 0 comments Download
M src/compiler/preprocessor/new/Diagnostics.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2
Alok Priyadarshi
13 years, 9 months ago (2012-06-29 21:30:37 UTC) #1
kbr1
13 years, 9 months ago (2012-06-29 21:46:12 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b